joinmarket: Add option settings
#722
Merged
+150
−152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikarvstedt
force-pushed
the
joinmarket-settings
branch
4 times, most recently
from
e83173a to
6875d04
Compare
erikarvstedt
force-pushed
the
joinmarket-settings
branch
from
6875d04 to
5552e76
Compare
|
I've removed option |
erikarvstedt
force-pushed
the
joinmarket-settings
branch
from
5552e76 to
d90a210
Compare
seberm
reviewed
Jul 27, 2024
There was a problem hiding this comment.
Hello @erikarvstedt , I've tried to run the code on my testing node. All of the settings were deployed successfuly and the services seems to be running fine. I think it's good to go.
jonasnick
reviewed
Jul 28, 2024
erikarvstedt
force-pushed
the
joinmarket-settings
branch
from
d90a210 to
2ba89c2
Compare
These options are set by default in `jmclient/configure.py` and don't need to be repeated. Some options, like those in section `POLICY`, might be assigned more suitable default values in future joinmarket releases, so don't override them in nix-bitcoin.
erikarvstedt
force-pushed
the
joinmarket-settings
branch
from
2ba89c2 to
9d9e921
Compare
jonasnick
previously approved these changes
Aug 2, 2024
|
I think we can merge this now. |
erikarvstedt
force-pushed
the
joinmarket-settings
branch
from
9d9e921 to
8ba98f7
Compare
Joinmarket settings can now be freely specified.
erikarvstedt
force-pushed
the
joinmarket-settings
branch
from
8ba98f7 to
cf3f0db
Compare
jonasnick
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Joinmarket settings can now be freely specified:
Closes #707
The updated
joinmarket-ob-watcheris deployed at https://nixbitcoin.org and is working fine.@seberm, can you help reviewing and testing this?