Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sgxs-tools failed to compile when using feature pe2sgxs on nightly #433

Closed
Taowyoo opened this issue Feb 6, 2023 · 3 comments · Fixed by #442
Closed

sgxs-tools failed to compile when using feature pe2sgxs on nightly #433

Taowyoo opened this issue Feb 6, 2023 · 3 comments · Fixed by #442
Labels
bug

Comments

@Taowyoo
Copy link
Collaborator

Taowyoo commented Feb 6, 2023 •
edited
Loading

This is because dependency is failed to compile because of recent update of rust nightly:

make unaligned_reference a hard error #102513

The dependency jethrogb/pe-rs need to update to fix this.

Created corresponding issue in pe-rs : jethrogb/pe-rs#6
@Taowyoo Taowyoo added the bug label Feb 6, 2023
@Taowyoo
Copy link
Collaborator Author

Taowyoo commented Feb 6, 2023

Found this error from recent PR: #432

Taowyoo added a commit that referenced this issue Feb 6, 2023
@Taowyoo
ci: pin rust version to nightly-2023-01-31 to avoid error mentioned i…
c10e404 
…n issue #433
@Taowyoo Taowyoo mentioned this issue Apr 24, 2023
Merged
@jethrogb
Copy link
Member

Can we please fix this ASAP as we are no longer able to test on stable

@Taowyoo
Copy link
Collaborator Author

Taowyoo commented Apr 26, 2023 •
edited
Loading

Pls check PR jethrogb/pe-rs#7

@Taowyoo Taowyoo mentioned this issue Apr 26, 2023
Closed
@arai-fortanix arai-fortanix mentioned this issue Apr 26, 2023
Merged
@Taowyoo Taowyoo mentioned this issue Apr 27, 2023
Merged
@bors bors bot closed this as completed in 11e11c0 May 4, 2023
Taowyoo added a commit that referenced this issue May 30, 2023
@bors @Taowyoo
Merge #442
c78510d 
442: fix pe error by removing `isgx-pe2sgx` in CI r=Taowyoo a=Taowyoo

Fix #433 by removing `isgx-pe2sgx` in CI

If it's not used, maybe we could also remove the code.

Please correct me if it's actively used somewhere

Co-authored-by: Yuxiang Cao <yuxiang.cao@fortanix.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix pe error by removing isgx-pe2sgx in CI fortanix/rust-sgx
2 participants
@jethrogb @Taowyoo