Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump dependency of mbedtls to 0.10.0 #441

Closed
wants to merge 19 commits into from
Closed

Bump dependency of mbedtls to 0.10.0 #441

wants to merge 19 commits into from

Conversation

Taowyoo
Copy link
Collaborator

@Taowyoo Taowyoo commented Apr 27, 2023 •
edited
Loading

This PR is based on

And need to be merged after it.

TL;DR

  • bumps dependency mbedtls 's version to 0.10.0
  • bumps updated crates' version

Changes

Note: I assume force to use mbedtls 0.10.0 is an incompatible change.

  • em-app
    • bump version 0.3.1 to 0.4.0
    • bump dependency mbedtls : 0.8.1 to 0.10.0
    • extend dependency pkix : 0.1.2 to >=0.1.2, <0.3.0
    • update code yo sync with API changes in mbedtls 0.10.0
    • bump version & update code in examples: get-certificate & harmonize
  • fortanix-vme/aws-nitro-enclaves/nitro-attestation-verify
    • bump version 0.1.1 to 0.2.0
    • bump dependency mbedtls : 0.8.2 to 0.10.0
    • extend dependency pkix : 0.1 to >=0.1.2, <0.3.0
    • update code to sync with API changes in mbedtls 0.10.0
  • fortanix-vme/aws-nitro-enclaves/tests/nsm-test
    • extend dependency pkix : 0.1 to >=0.1.1, <0.3.0
  • fortanix-vme/vme-pkix
    • extend dependency pkix : 0.1 to >=0.1.1, <0.3.0
  • intel-sgx/dcap-ql
    • bump version 0.3.5 to 0.3.6
    • extend dependency mbedtls : 0.8.0 to 0.10.0
  • intel-sgx/ias
    • bump version 0.1.1 to 0.1.2
    • extend dependency pkix : 0.1 to >=0.1.1, <0.3.0
    • extend dependency mbedtls : 0.8.0 to 0.10.0
  • intel-sgx/sgx-isa
    • bump version 0.4.0 to 0.4.1
    • extend dependency mbedtls : 0.8.0 to 0.10.0

@Taowyoo Taowyoo mentioned this pull request Apr 27, 2023
Closed
@Taowyoo Taowyoo force-pushed the yx/new-async-usercalls_update-mbedtls branch 2 times, most recently from 937bd56 to 131ff8a Compare April 27, 2023 18:22
@Taowyoo Taowyoo changed the base branch from master to mz/new-async-usercalls April 27, 2023 21:21
@jethrogb
Copy link
Member

Shouldn't have a PR for master?

@jethrogb
Copy link
Member

Crate version changes don't really mean anything in this branch.

@Taowyoo
Copy link
Collaborator Author

Taowyoo commented Apr 28, 2023 via email •
edited
Loading

@jethrogb
Copy link
Member

We only publish to crates.io from the master branch

@Taowyoo Taowyoo changed the base branch from mz/new-async-usercalls to master April 28, 2023 16:14
@arai-fortanix
Copy link
Contributor

We only publish to crates.io from the master branch

Maybe I'm not understanding you, but that's not true. In order to publish fixes to old versions of crates (like sgx_pkix 1.4, where master is on incompatible 2.1), we have to publish from non-master branches.

@jethrogb
Copy link
Member

jethrogb commented May 1, 2023

Right. I meant feature branches.

@Taowyoo Taowyoo marked this pull request as draft May 25, 2023 23:19
@Taowyoo Taowyoo changed the title Bump dependency of mbedtls to 0.9.0 Bump dependency of mbedtls to 0.10.0 May 25, 2023
@Taowyoo Taowyoo changed the title Bump dependency of mbedtls to 0.10.0 Bump dependency of mbedtls to 0.9.0 Jun 2, 2023
@Taowyoo Taowyoo changed the title Bump dependency of mbedtls to 0.9.0 Bump dependency of mbedtls to 0.10.0 Jun 8, 2023
@Taowyoo Taowyoo force-pushed the yx/new-async-usercalls_update-mbedtls branch 2 times, most recently from 1b0cf7c to 1ce2298 Compare June 8, 2023 21:06
@Taowyoo Taowyoo self-assigned this Jun 8, 2023
@Taowyoo Taowyoo force-pushed the yx/new-async-usercalls_update-mbedtls branch 2 times, most recently from 514482f to 84e58f6 Compare June 9, 2023 18:36
mzohreva and others added 5 commits June 15, 2023 17:41
@mzohreva @Taowyoo
Cancel queue
d74b7b0
@mzohreva @Taowyoo
Async usercall interface for SGX enclaves
3001201
@mzohreva @Taowyoo
Fix race condition when cancel is received before usercall
be9fd64 
`UsercallEvent::Start` was being sent in `fn handle_usercall`,
which is too late. It needs to be sent before we receive the next
usercall from the enclave so we can maintain the invariant that
"we only need to keep track of cancels received before the actual
usercall if the read position has not moved past the write position
when cancel was received."
@raoulstrackx @Taowyoo
Verify allocation FifoDescriptor
104d151
@raoulstrackx @Taowyoo
Making read_epoch AtomicU64
c8c68d9
mzohreva and others added 12 commits June 15, 2023 17:41
@mzohreva @Taowyoo
Post rebase fixes
6bd6f34 
- Move async-usercalls to intel-sgx directory
- Remove hacks/unsafe_typecasts.rs
- Fix some typos in docs
- Use marker trait for MakeSend to avoid warnings about issue #93367
- Update crossbeam and crossbeam-channel dependencies
- Use nightly Rust in CI
- Use SGX target for generating docs when crate has `feature(sgx_platform)`
@mzohreva @Taowyoo
Update fortanix-sgx-abi dependency and restore path dependencies
969a0f5
@mzohreva @Taowyoo
Add documentation for async-usercalls and address other minor issues
bdeceb9
@mzohreva @Taowyoo
Remove almost all hacks
cc95cab
@Taowyoo
resolve rebase conflict
7a6387e
@Taowyoo
bump version
8bc3047 
- Bump em-app,nitro-attestation-verify's dependency of `mbedtls`
  to 0.9.0
- Extend dcap-ql,ias,sgx-isa's dependency of `mbedtls` to
  ">=0.8.0, <0.10.0" since there is no api changes from  `mbedtls`
@Taowyoo
extend compatible pkix version
8d1c2d3
@Taowyoo
update code for api changes in mbedtls
3a871a2
@Taowyoo
upgrade dep mbedtls to 0.10.0
b3b9f74 
Signed-off-by: Yuxiang Cao <yuxiang.cao@fortanix.com>
@Taowyoo
update Cargo.lock
768b627
@Taowyoo
fix(nitro-attestation-verify): update error & fix tests
5cc82bc
@Taowyoo
ci: use nightly-2023-05-07 rust
dfd59ee
@Taowyoo Taowyoo force-pushed the yx/new-async-usercalls_update-mbedtls branch from 84e58f6 to dfd59ee Compare June 16, 2023 00:47
@raoulstrackx raoulstrackx mentioned this pull request Jul 21, 2023
Open
vn971 pushed a commit to vn971/rust-sgx that referenced this pull request Aug 28, 2023
Async usercall interface for SGX enclaves
12728f3 
Credits for this commit go to:
Mohsen: fortanix#404
YxC: fortanix#441

This commit is an attempt to have the async-usercalls finally merged
into the main codebase (master branch).
@vn971 vn971 mentioned this pull request Aug 28, 2023
Merged
vn971 pushed a commit to vn971/rust-sgx that referenced this pull request Aug 29, 2023
Async usercall interface for SGX enclaves
f917b37 
Credits for this commit go to:
Mohsen: fortanix#404
YxC: fortanix#441

This commit is an attempt to have the async-usercalls finally merged
into the main codebase (master branch).
@Taowyoo
Copy link
Collaborator Author

Taowyoo commented Sep 7, 2023 •
edited
Loading

Since C mbedlts is not thread safe in TLS 1.3 in 3.X version.The upgrade of mbedtls has been shutdown.

So I declined this PR

@Taowyoo Taowyoo closed this Sep 7, 2023
raoulstrackx pushed a commit that referenced this pull request Jan 4, 2024
@raoulstrackx
Async usercall interface for SGX enclaves
0dc531f 
Credits for this commit go to:
Mohsen: #404
YxC: #441

This commit is an attempt to have the async-usercalls finally merged
into the main codebase (master branch).
vn971 pushed a commit that referenced this pull request Jan 4, 2024
Async usercall interface for SGX enclaves
1e6a9d4 
Credits for this commit go to:
Mohsen: #404
YxC: #441

This commit is an attempt to have the async-usercalls finally merged
into the main codebase (master branch).
vn971 pushed a commit to vn971/rust-sgx that referenced this pull request Jan 17, 2024
Async usercall interface for SGX enclaves
37461c2 
Credits for this commit go to:
Mohsen: fortanix#404
YxC: fortanix#441

This commit is an attempt to have the async-usercalls finally merged
into the main codebase (master branch).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzohreva mzohreva Awaiting requested review from mzohreva

@jethrogb jethrogb Awaiting requested review from jethrogb

@raoulstrackx raoulstrackx Awaiting requested review from raoulstrackx

@arai-fortanix arai-fortanix Awaiting requested review from arai-fortanix

@Pagten Pagten Awaiting requested review from Pagten

Assignees

@Taowyoo Taowyoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Taowyoo @jethrogb @arai-fortanix @mzohreva @raoulstrackx