Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Spot instance for PAYG #106

Merged
merged 3 commits into from
Jul 25, 2023
Merged

Conversation

jvhoof
Copy link
Contributor

@jvhoof jvhoof commented Jun 22, 2023

By default, spot instances are enable in the autoscale template for the PAYG VMSS deployment. Spot instances have become more difficult to get a hold of recently and are not optimal for a statefull firewall. They can be evicted at any time resulting in dead connections.

https://azure.microsoft.com/en-us/products/virtual-machines/spot/

Copy link
Contributor

@JaydenLiang JaydenLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jvhoof , you have a templates/blah file here. What is it used for?

@jvhoof
Copy link
Contributor Author

jvhoof commented Jul 21, 2023

@JaydenLiang That was a temporary clipboard that I should have removed. Removed from the PR now.

@JaydenLiang JaydenLiang merged commit 2e0b597 into fortinet:main Jul 25, 2023
2 checks passed
@jvhoof jvhoof deleted the FixPAYGSpotInstance branch January 3, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants