Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make extra unknown flags in config map a warning/error but not prevent watching #44

Closed
ldemailly opened this issue Oct 9, 2023 · 0 comments · Fixed by #45
Closed

Make extra unknown flags in config map a warning/error but not prevent watching #44

ldemailly opened this issue Oct 9, 2023 · 0 comments · Fixed by #45

Comments

@ldemailly
Copy link
Member

Right now you get

16:05:52.562 r1 [CRI] scli.go:80> Unable to watch config/flag changes in ./config-dir: encountered 2 errors while parsing flags from directory  
  flag bar: flag not found
flag foo: flag not found

and the (other) flags are read at start up (good at least) but then further change to the cmap are ignored
ldemailly added a commit that referenced this issue Oct 10, 2023
@ldemailly
Additional/unknown flags are warnings only now. Fixes #44
087897a
@ldemailly ldemailly mentioned this issue Oct 10, 2023
Merged
ldemailly added a commit that referenced this issue Oct 10, 2023
@ldemailly
Additional/unknown flags in configmaps/directories are warnings only …
76ec073 
…now. (#45)

* Additional/unknown flags are warnings only now. Fixes #44

* deal with thread safety

* go get -u ./...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Additional/unknown flags in configmaps/directories are warnings only now. fortio/dflag
1 participant
@ldemailly