Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a String() to Set and Array so it looks better on UI and symetrical with coma input #4

Merged
merged 6 commits into from
Feb 21, 2023

Conversation

ldemailly
Copy link
Member

@ldemailly ldemailly commented Feb 20, 2023

Also added tests and example

Also adding a bunch of Set functions (NewSet, Add, Has, Remove, Clone) into a new fortio.org/sets package

@ldemailly ldemailly changed the title Add a String() to Set so it looks better on UI and symetrical with co… Add a String() to Set and Array so it looks better on UI and symetrical with coma input Feb 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2023

Codecov Report

Base: 83.83% // Head: 83.96% // Increases project coverage by +0.12% 🎉

Coverage data is based on head (955f8fb) compared to base (867970e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
+ Coverage   83.83%   83.96%   +0.12%     
==========================================
  Files          14       14              
  Lines         532      530       -2     
==========================================
- Hits          446      445       -1     
+ Misses         72       71       -1     
  Partials       14       14              
Impacted Files Coverage Δ
endpoint/endpoint.go 58.51% <ø> (ø)
dyngeneric.go 100.00% <100.00%> (+1.45%) ⬆️
dynstringset.go 56.25% <100.00%> (ø)
configmap/updater.go 77.16% <0.00%> (-0.79%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ldemailly ldemailly merged commit f0851c9 into main Feb 21, 2023
@ldemailly ldemailly deleted the set_coma branch February 21, 2023 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants