Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gcc/macos): don't meddle with lib locations #62

Merged
merged 1 commit into from
Feb 25, 2024

Conversation

wpbonelli
Copy link
Contributor

@wpbonelli wpbonelli commented Feb 25, 2024

Bad idea carried in from modflowpy/install-gfortran-action, likely behind #32, blame is mine

@gha3mi @jalvesz it would be good to confirm if pointing workflows at fortran-lang/setup-fortran@main solves the problem. Or provided a repo link happy to fork and test

@wpbonelli wpbonelli merged commit e9da799 into fortran-lang:main Feb 25, 2024
159 checks passed
@wpbonelli wpbonelli deleted the macos-fix branch February 25, 2024 02:55
@gha3mi
Copy link
Contributor

gha3mi commented Feb 25, 2024

      matrix:
        os: [ubuntu-latest, windows-latest, macos-latest]
        toolchain:
          - {compiler: gcc}
          - {compiler: intel}
          - {compiler: intel-classic}
          - {compiler: nvidia-hpc}
        exclude:
          - os: windows-latest
            toolchain: {compiler: nvidia-hpc}
          - os: macos-latest
            toolchain: {compiler: nvidia-hpc}

This is the output of my test on macOS using fpm. It seems the problem is still there:

Run fpm test --profile debug --compiler gfortran
  fpm test --profile debug --compiler gfortran
  shell: /bin/bash -e {0}
  env:
    FC: gfortran
    CC: gcc
    CXX: g++
dyld[2541]: Library not loaded: '/usr/local/opt/gcc@10/lib/gcc/10/libgfortran.5.dylib'
  Referenced from: '/Users/runner/work/_temp/fpm'
  Reason: tried: '/usr/local/opt/gcc@10/lib/gcc/10/libgfortran.5.dylib' (no such file), '/usr/local/lib/libgfortran.5.dylib' (no such file), '/usr/lib/libgfortran.5.dylib' (no such file)
/Users/runner/work/_temp/e291837c-5003-424d-8092-a092b268976e.sh: line 1:  2541 Abort trap: 6           fpm test --profile debug --compiler gfortran
Error: Process completed with exit code 134.

@wpbonelli
Copy link
Contributor Author

@gha3mi any chance you could put together a minimal reproduction and test? #31

@gha3mi
Copy link
Contributor

gha3mi commented Feb 25, 2024

@wpbonelli I have created a test repository. Feel free to push directly to the main branch. If you think it should be private, let me know.
https://github.com/gha3mi/test-setup-fortran

@gha3mi
Copy link
Contributor

gha3mi commented Mar 1, 2024

@wpbonelli The test has been extended to include fpm, cmake, cmake+ninja, and meson. Please check out: https://github.com/gha3mi/test-setup-fortran.

@wpbonelli
Copy link
Contributor Author

Thanks @gha3mi that is great, if you make progress towards a solution feel free to add a PR here. I probably won't be able to take a close look for the next week or so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants