Improved support for NAG #418
Conversation
test_mean_f03.f90 cause floating invalid operation error because some variable is not initialized.
Optional argument value has been passed for the first argument of merge routine. some compiler can't allow such situation.
The Fortran standard says "The value of a file-unit-number shall identify a valid unit.". Once the newunit value generated by open(newunit=..) is not connected to a unit, it is not valid. When the unit number is not valid, the compiler can do anything from return .TRUE., .FALSE., raise an error. Therefore, I added the iostat argument for the inquire routine.
Adding white spaces Co-authored-by: Sebastian Ehlert <28669218+awvwgk@users.noreply.github.com>
Delete unused character.
Changed to work even when string size is 0.
ichar(" ") should be alloed.
| if (allocated(string%raw) .and. len(string) > 0) then | ||
| ich = ichar(string%raw(1:1)) | ||
| else | ||
| ich = 0 | ||
| end if |
There was a problem hiding this comment.
May I ask what was the issue with the original code?
There was a problem hiding this comment.
Accordings to the book 'Modern Fortran explained (Incorporating Fortran 2018)', argument of 'ichar' is a character.
'string%raw' can be more than length one. In such case, runtime error occurred when use nagfor. On the other hands, gfortran seems to accept string argument.
There was a problem hiding this comment.
Thank you @sakamoti for your answer. But I was wondering why the merge option was removed.
There was a problem hiding this comment.
merge doesn't necessarily short-circuit the evaluation of its arguments like a ternary operator in C would. This could lead to an access of the uninitialized raw payload of the string_type which is an error.
There was a problem hiding this comment.
Thanks @awvwgk for the explanation.
There was a problem hiding this comment.
I havn't know which one is more efficiently to select 'merge' or 'if construct'. I just felt a bit complex to write with 'merge'. And I want to acces 'string%raw' only when 'conditions' becoms true. So, I select to write with 'if construct'.
Thank you @awvwgk for the explanation.
awvwgk
added
compilers
and removed
reviewers needed
Because of nagfor's strict error checking characteristics, execution is halted by default when a floating point exception occurs. Some of the runtime errors can be resolved by adding the option '-ieee=full'.
Other errors have been corrected to conform more strictly to the fortran standard.
These commit still leaves the one runtime error 'string_derivedtype_io'.
#108