feat: updates options on Configuration change #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An interface to the linter options has been implemented that fetches new options whenever a configuration change is detected. This also solves the problem of constantly having to call getconfiguration in various parts of the linter
Updates built-in symbol definition provider as a fallback solution
Discards the verbose spawn call to the linter and replaces it with spawnAsPromise. Makes the relevant linting routines async and also allows the linter to return the diagnostics for the URI to aid with unittesting. The unittests for the default and fypp linter have now been fixed.
Revert commit when [FEAT] Gfortran v11+enhanced linting support #523 is fullfiled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An interface to the linter options has been implemented that
fetches new options whenever a configuration change is
detected.
This also solves the problem of constantly having to call
getconfiguration in various parts of the linter