Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): improve GNU regex for modern options #819

Merged
merged 2 commits into from
Feb 2, 2023
Merged

Conversation

gnikit
Copy link
Member

@gnikit gnikit commented Feb 2, 2023

We explicitly try to capture a version that fits the sever pattern
as part of the original line message. If not, a warning is
thrown which indicates that the fallback, less robust options
for older versions of GFortran will be used.

Fixes #813
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #819 (869ac59) into main (3d79339) will not change coverage.
The diff coverage is 33.33%.

@@           Coverage Diff           @@
##             main     #819   +/-   ##
=======================================
  Coverage   82.84%   82.84%           
=======================================
  Files          12       12           
  Lines        2273     2273           
  Branches      203      204    +1     
=======================================
  Hits         1883     1883           
  Misses        383      383           
  Partials        7        7           
Impacted Files Coverage Δ
src/features/linter-provider.ts 80.06% <33.33%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gnikit gnikit merged commit da7ab3d into main Feb 2, 2023
@gnikit gnikit deleted the gnikit/issue813 branch February 2, 2023 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant