This repository has been archived by the owner on Jun 28, 2019. It is now read-only.
Requires aws-sdk-ec2 rather than aws-sdk #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanSith
pushed a commit
to missiondata/cap-ec2-old
that referenced
this pull request
Nov 5, 2018
SeanSith
pushed a commit
to missiondata/cap-ec2-old
that referenced
this pull request
Nov 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #78
In pull request #76, a change was made to allow either AWS SDK v2 or v3 with
cap-ec2.However, the dependency on the
aws-sdkv3 gem means that all other AWS gems get pulled in to the project, even if they are not desired.In this PR, I make the required dependency be just on
aws-sdk-ec2. For those using the AWS SDK v3, this can result in many gems no longer being needed just to runcap-ec2.However, this is a breaking change as it would mean
cap-ec2will no longer work with AWS SDK v2. Merging this PR should probably require a major release increment for the gem.