-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat search requests #330
Feat search requests #330
Conversation
This reverts commit a904b2e.
…t when nothing matches query
@ashitaprasad fixed the bug with last PR |
I would like you to spend some time on the problem and think it through. |
…a temp sequence variable
I had implemented the search provider as a failsafe to show a circular loader when searching queries (loader UI change was not pushed with the commits somehow) in a big list or queries. I removed it now as I tested using 100 requests and there was no visible lagging in showing the filtered list. |
Review your code. The approach is still incorrect. This feature can be implemented at UI level without touching providers. |
I am manipulating only the request sequence provider to trigger UI change using a filter function in collection provider. Could you provide your thought for the filtering approach? I can relocate the filter function outside the provider but manipulating the request sequence would be necessary to trigger the UI change. |
This feature has been implemented. Closing this PR. |
PR Description
This allows a user to search request based on name or url. When no request found an indicative text will be shown.
Fixed Renderflex issue in codegen language dropdown.
Related Issues
Checklist
main
branch before making this PRflutter test
) and all tests are passingAdded/updated tests?
Screen.Recording.2024-03-20.at.12.37.22.AM.mov