Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat search requests #330

Closed

Conversation

yashas-hm
Copy link
Contributor

@yashas-hm yashas-hm commented Mar 19, 2024

PR Description

This allows a user to search request based on name or url. When no request found an indicative text will be shown.

Fixed Renderflex issue in codegen language dropdown.

Related Issues

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have run the tests (flutter test) and all tests are passing

Added/updated tests?

  • No, and this is why: Wasn't sure which tests to include
Screen.Recording.2024-03-20.at.12.37.22.AM.mov

@yashas-hm
Copy link
Contributor Author

@ashitaprasad fixed the bug with last PR

@animator
Copy link
Member

I would like you to spend some time on the problem and think it through.
Do you even require any provider to solve this problem?

@yashas-hm
Copy link
Contributor Author

I had implemented the search provider as a failsafe to show a circular loader when searching queries (loader UI change was not pushed with the commits somehow) in a big list or queries. I removed it now as I tested using 100 requests and there was no visible lagging in showing the filtered list.

@animator
Copy link
Member

Review your code. The approach is still incorrect. This feature can be implemented at UI level without touching providers.

@yashas-hm
Copy link
Contributor Author

I am manipulating only the request sequence provider to trigger UI change using a filter function in collection provider. Could you provide your thought for the filtering approach?

I can relocate the filter function outside the provider but manipulating the request sequence would be necessary to trigger the UI change.

@animator
Copy link
Member

This feature has been implemented. Closing this PR.

@animator animator closed this Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a search/filter for collection pane
2 participants