Resolve issue 359 #413
Resolve issue 359 #413
Conversation
|
Check |
|
I am extremely sorry if this is because of me using arch but it requires |
|
Did you read my comment above? |
`file_selector` pkg & used rm useless pkgs
|
@Sarath191181208 is this PR ready for review? |
|
Yes |
| /// | ||
| /// You can provide a [subDir] where the boxes should be stored. | ||
| Future<void> initHiveWithRootFolder(String appDir, [String? subDir]) async { | ||
| WidgetsFlutterBinding.ensureInitialized(); |
There was a problem hiding this comment.
WidgetsFlutterBinding.ensureInitialized(); should not be hidden in this function. It should be in main() as it is currently.
|
|
||
| init(join(appDir, subDir)); | ||
| } | ||
| } |
There was a problem hiding this comment.
What is the purpose of this extension. This task can be done by a hive utility function.
| @@ -0,0 +1,30 @@ | |||
| // Store hive save folder path. | |||
There was a problem hiding this comment.
These are not models. They are shared_preferences utility functions.
| Future<void> openBoxes() async { | ||
| await Hive.initFlutter(); | ||
| Future<void> openBoxes(String hiveSaveFolder) async { | ||
| await Hive.initHiveWithRootFolder(hiveSaveFolder); |
There was a problem hiding this comment.
Will get changed according to the comment above
| import 'package:apidash/services/hive_services.dart'; | ||
| import 'package:flutter/material.dart'; | ||
|
|
||
| class HiveDirectorySelector extends StatefulWidget { |
There was a problem hiding this comment.
Does it require a Stateful Widget or Stateless can work?
Selecting a hive persistence folder
The flow of the app is as follows:
file_pickerpackage.shared_preferences.NOTE: On Linux
file_pickerrequires thezenitypackage for picking files.Related Issues
Checklist
mainbranch before making this PRflutter test) and all tests are passing, except one test in /apidash/test/models/response_model_test.dart due to invalid SSL certificate of https://api.apidash.dev/Added/updated tests?
We encourage you to add relevant test cases.