Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript error #1030

Closed
fmunch opened this issue Apr 10, 2018 · 1 comment · Fixed by #1031
Closed

JavaScript error #1030

fmunch opened this issue Apr 10, 2018 · 1 comment · Fixed by #1031
Labels
Milestone

Comments

@fmunch
Copy link
Contributor

fmunch commented Apr 10, 2018

Hello,

Since 2.18 I have many JavaScript errors:

Uncaught TypeError: selfoss.ui.refreshEntryStatuses is not a function
    at Object.success (all.js?v=1520262850:1085)
    at fire (all.js?v=1520262850:187)
    at Object.fireWith [as resolveWith] (all.js?v=1520262850:193)
    at done (all.js?v=1520262850:538)
    at XMLHttpRequest.<anonymous> (all.js?v=1520262850:554)

This probably happens after every update of the sources, but does not seem to affect the overall behavior of the application.

selfoss-db.js calls selfoss.ui.refreshEntryStatuses (defined in selfoss-ui.js). cfb5d29 changed the function name from refreshItemStatuses to refreshEntryStatuses in both files, but e55ef1b reverted the change in selfoss-ui.js only.

@niol
Copy link
Collaborator

niol commented Apr 10, 2018

This failure prevents the ui from being updated if you've read some items on another device (shows read items as read and updates unread counts) while selfoss was open on another.
You seem to have sorted this out, maybe you can submit a pull request?

fmunch added a commit to fmunch/selfoss that referenced this issue Apr 10, 2018
@jtojnar jtojnar added the bug label Apr 20, 2018
@jtojnar jtojnar added this to the 2.19 milestone Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants