Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double text on sources page in Firefox 55 #975

Closed
klundry opened this issue Aug 16, 2017 · 1 comment
Closed

Double text on sources page in Firefox 55 #975

klundry opened this issue Aug 16, 2017 · 1 comment
Labels
bug ux

Comments

@klundry
Copy link

klundry commented Aug 16, 2017 •
edited
Loading

I have just updated to Firefox 55.0.1 on Arch and now when I go to the sources page I get a weird double text over top of some of the sources. But not all. This may be similar to a closed issue from a couple years ago #536.

screenshot_20170815_194007
@jtojnar
Copy link
Member

jtojnar commented Aug 16, 2017

These are the alt texts for the missing favicons. We can safely make the alt text empty like we did in the item view.

In the future we might want to do something about the missing icons, like re-fetching them or saving them to the db.

jtojnar added a commit that referenced this issue Aug 17, 2017
@jtojnar
Drop alt attribute of source favicons
5ad0a92 
The favicons in the source list contained the title of the feed in
their alt attribute. This was redundant since the title is already
shown next to the item, resulting in the title being read multiple
times by accessibility technologies. It was also displayed over
the title when the favicon file was missing.

Closes: #975
@jtojnar jtojnar mentioned this issue Aug 17, 2017
Merged
jtojnar added a commit that referenced this issue Oct 3, 2017
@jtojnar
Drop alt attribute of source favicons
697697c 
The favicons in the source list contained the title of the feed in
their alt attribute. This was redundant since the title is already
shown next to the item, resulting in the title being read multiple
times by accessibility technologies. It was also displayed over
the title when the favicon file was missing.

Closes: #975
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug ux
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jtojnar @klundry