Add timestamp to export-filename #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
requested changes
Jan 21, 2019
controllers/Opml.php
Outdated
| @@ -343,7 +343,8 @@ public function export() { | |||
| \F3::get('logger')->debug('finished OPML export'); | |||
|
|
|||
| // save content as file and suggest file name | |||
| header('Content-Disposition: attachment; filename="selfoss-subscriptions.xml"'); | |||
| $export_name = "selfoss-subscriptions-" . date('YmdHis') . ".xml"; | |||
There was a problem hiding this comment.
Could you use the ISO format so that the date is more legible?
Suggested change
| $export_name = "selfoss-subscriptions-" . date('YmdHis') . ".xml"; | |
| $exportName = 'selfoss-subscriptions-' . date('Y-m-d\TH:i:s') . '.xml'; |
There was a problem hiding this comment.
The formatted date is a problem, as ':' is not allowed in filenames. Will be replaced by '_' and looks weird. I would prefer keeping the raw timestamp.
There was a problem hiding this comment.
What about Ymd\THi? That should be at least little bit more readable.
There was a problem hiding this comment.
OK, I'll change it, but keeping the seconds as well.
Ymd\THis
There was a problem hiding this comment.
I have decided to remove the T after all. It just looks weird.
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To track the history of subscriptions, this adds a timestamp to the proposed export-filename.
selfoss-subscription.xml becomes selfoss-subscriptions-20190121160154.xml