Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

offline: various fixes #1136

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

offline: various fixes #1136

wants to merge 1 commit into from

Conversation

niol
Copy link
Collaborator

@niol niol commented Sep 23, 2019

No description provided.

public/js/selfoss-db.js Outdated Show resolved Hide resolved
@jtojnar
Copy link
Member

jtojnar commented May 3, 2020

I have rebased this and switched the part to use async functions since we now use Babel and they are supported by Dexie.transaction(). It is even cleaner than the Promise.all I suggested before.

We might still want to switch to sending JSON instead of urlencoded form data (as I did in #1182) but this seems to work reliably enough.

@jtojnar jtojnar marked this pull request as ready for review May 3, 2020 05:41
@jtojnar jtojnar added this to the 2.19 milestone May 3, 2020
@jtojnar jtojnar added the bug label May 3, 2020
This is to avoid getting:
    PHP Warning: Unknown: Input variables exceeded 1000. To increase the limit change max_input_vars in php.ini.

after reading a lot of items offline.
Copy link
Collaborator Author

@niol niol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will test when I get some time to grasp the new build system and backport my changes on top of it.

@jtojnar jtojnar removed this from the 2.19 milestone May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants