client: Update to ESLint 9 #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESLint 9 deprecates the eslintrc settings format, let’s switch to the new flat format. https://eslint.org/blog/2023/10/flat-config-rollout-plans/ https://eslint.org/blog/2022/08/new-config-system-part-1/ https://eslint.org/blog/2022/08/new-config-system-part-2/ - `--ext` flag not supported with flat config, using files option https://eslint.org/docs/latest/use/configure/migration-guide#--ext `.jsx` not part of the default extension set so we still need to add it: https://eslint.org/docs/latest/use/configure/configuration-files#specifying-files-with-arbitrary-extensions - Since we want to imports in the config, we need to change package type to `module`. - `eslint-plugin-react-hooks` does not currently setup flat config so we need to work around it by creating it ourselves or using `@eslint/compat`.
Gets rid of the following warning:
Warning: React version not specified in eslint-plugin-react settings. See https://github.com/jsx-eslint/eslint-plugin-react#configuration .
✅ Deploy Preview for selfoss canceled.
|
- ESLint 9: https://eslint.org/blog/2024/04/eslint-v9.0.0-released/ https://eslint.org/docs/latest/use/migrate-to-9.0.0 - Lints current directory without any arguments: https://eslint.org/docs/latest/use/migrate-to-9.0.0#-change-in-behavior-when-no-patterns-are-passed-to-cli - eslint-plugin-react-hooks: https://github.com/facebook/react/blob/eslint-plugin-react-hooks%405.0.0/packages/eslint-plugin-react-hooks/CHANGELOG.md - eslint-plugin-react: https://www.github.com/jsx-eslint/eslint-plugin-react/pull/3759 - Prettier config not as necessary since ESLint 9 phased out stylistic lints: https://www.github.com/prettier/eslint-config-prettier/issues/290 But there are some rules that are still enabled by recommended `@eslint/js` config. It is possible to check them with `npx eslint-config-prettier js/index.js`. In our case `no-unexpected-multiline` is still enabled: https://github.com/prettier/eslint-config-prettier/tree/v9.1.0#special-rules
jtojnar
force-pushed
the
wip/jtojnar/eslint9
branch
from
88721aa to
b4aa33f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1490