Coding style #870
Merged
Coding style #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
commented
Feb 6, 2017
controllers/Index.php
Outdated
| } else { | ||
| if($itemDao->hasMore()) | ||
| $itemsHtml .= '<div class="stream-more"><span>'. \F3::get('lang_more').'</span></div>'; | ||
| $itemsHtml .= '<div class="mark-these-read"><span>'. \F3::get('lang_markread').'</span></div>'; |
There was a problem hiding this comment.
No indention is wrong here: the button should be shown even if there are no more items to show, because it is intended to mark visible items as read.
Note: this code is removed by #846.
jtojnar
force-pushed
the
cs
branch
2 times, most recently
from
732a1b6 to
bfeb5d7
Compare
jtojnar
force-pushed
the
cs
branch
3 times, most recently
from
6ed01c5 to
730b095
Compare
jtojnar
force-pushed
the
cs
branch
2 times, most recently
from
416751e to
b8f228e
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be merged once all other pending PRs are merged.
Edit: Coincidentally, it also fixes PHP 7.2 compatibility.