fix(builders): Don't fail on non-fatal missing binaries

fossas · Mar 20, 2018 · 70fc3a5 · 70fc3a5
1 parent 91944c9
commit 70fc3a5
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 10 deletions.
diff --git a/builders/bower.go b/builders/bower.go
@@ -52,15 +52,15 @@ func (builder *BowerBuilder) Initialize() error {
 	// Set Node context variables
 	nodeCmd, nodeVersion, err := which("-v", os.Getenv("NODE_BINARY"), "node", "nodejs")
 	if err != nil {
-		return fmt.Errorf("could not find Node binary (try setting $NODE_BINARY): %s", err.Error())
+		bowerLogger.Warningf("Could not find Node binary (try setting $NODE_BINARY): %s", err.Error())
 	}
 	builder.NodeCmd = nodeCmd
 	builder.NodeVersion = nodeVersion
 
 	// Set Bower context variables
 	bowerCmd, bowerVersion, err := which("-v", os.Getenv("BOWER_BINARY"), "bower")
 	if err != nil {
-		return fmt.Errorf("could not find Bower binary (try setting $BOWER_BINARY): %s", err.Error())
+		bowerLogger.Warningf("Could not find Bower binary (try setting $BOWER_BINARY): %s", err.Error())
 	}
 	builder.BowerCmd = bowerCmd
 	builder.BowerVersion = bowerVersion

diff --git a/builders/composer.go b/builders/composer.go
@@ -52,7 +52,7 @@ func (builder *ComposerBuilder) Initialize() error {
 	// Set PHP context variables
 	phpCmd, phpVersion, err := which("-v", os.Getenv("PHP_BINARY"), "php")
 	if err != nil {
-		return fmt.Errorf("could not find PHP binary (try setting $PHP_BINARY): %s", err.Error())
+		composerLogger.Warningf("Could not find PHP binary (try setting $PHP_BINARY): %s", err.Error())
 	}
 	builder.PHPCmd = phpCmd
 	builder.PHPVersion = phpVersion

diff --git a/builders/golang.go b/builders/golang.go
@@ -125,7 +125,7 @@ func (builder *GoBuilder) Initialize() error {
 	builder.VndrVersion = ""
 
 	if depErr != nil && glideErr != nil && godepErr != nil && govendorErr != nil && vndrErr != nil {
-		return fmt.Errorf("no supported Go build tools detected (try setting $DEP_BINARY or $GLIDE_BINARY or $GODEP_BINARY or $GOVENDOR_BINARY or $VNDR_BINARY): %#v %#v %#v %#v %#v", depErr, glideErr, godepErr, govendorErr, vndrErr)
+		goLogger.Warningf("No supported Go build tools detected (try setting $DEP_BINARY or $GLIDE_BINARY or $GODEP_BINARY or $GOVENDOR_BINARY or $VNDR_BINARY): %#v %#v %#v %#v %#v", depErr, glideErr, godepErr, govendorErr, vndrErr)
 	}
 
 	goLogger.Debugf("Done initializing Go builder: %#v", builder)

diff --git a/builders/maven.go b/builders/maven.go
@@ -65,7 +65,7 @@ func (builder *MavenBuilder) Initialize() error {
 	// Set Java context variables
 	javaCmd, javaVersion, err := which("-version", os.Getenv("JAVA_BINARY"), "java")
 	if err != nil {
-		return fmt.Errorf("could not find Java binary (try setting $JAVA_BINARY): %s", err.Error())
+		mavenLogger.Warningf("Could not find Java binary (try setting $JAVA_BINARY): %s", err.Error())
 	}
 	builder.JavaCmd = javaCmd
 	builder.JavaVersion = javaVersion

diff --git a/builders/nodejs.go b/builders/nodejs.go
@@ -57,7 +57,7 @@ func (builder *NodeJSBuilder) Initialize() error {
 	// Set NodeJS context variables
 	nodeCmd, nodeVersion, err := which("-v", os.Getenv("NODE_BINARY"), "node", "nodejs")
 	if err != nil {
-		return fmt.Errorf("could not find Node binary (try setting $NODE_BINARY): %s", err.Error())
+		nodejsLogger.Warningf("Could not find Node binary (try setting $NODE_BINARY): %s", err.Error())
 	}
 	builder.NodeCmd = nodeCmd
 	builder.NodeVersion = nodeVersion
@@ -73,7 +73,7 @@ func (builder *NodeJSBuilder) Initialize() error {
 	builder.YarnVersion = yarnVersion
 
 	if npmErr != nil && yarnErr != nil {
-		return fmt.Errorf("no supported Nodejs build tools detected (try setting $NPM_BINARY or $YARN_BINARY): %#v %#v", npmErr, yarnErr)
+		nodejsLogger.Warningf("No supported Nodejs build tools detected (try setting $NPM_BINARY or $YARN_BINARY): %#v %#v", npmErr, yarnErr)
 	}
 
 	nodejsLogger.Debugf("Initialized Nodejs builder: %#v", builder)

diff --git a/builders/ruby.go b/builders/ruby.go
@@ -57,15 +57,15 @@ func (builder *RubyBuilder) Initialize() error {
 	// Set Ruby context variables
 	rubyCmd, rubyVersion, err := which("-v", os.Getenv("RUBY_BINARY"), "ruby")
 	if err != nil {
-		return fmt.Errorf("could not find Ruby binary (try setting $RUBY_BINARY): %s", err.Error())
+		rubyLogger.Warningf("Could not find Ruby binary (try setting $RUBY_BINARY): %s", err.Error())
 	}
 	builder.RubyCmd = rubyCmd
 	builder.RubyVersion = rubyVersion
 
 	// Set Gem context variables
 	gemCmd, gemVersion, err := which("-v", os.Getenv("GEM_BINARY"), "gem")
 	if err != nil {
-		return fmt.Errorf("could not find Gem binary (try setting $GEM_BINARY): %s", err.Error())
+		rubyLogger.Warningf("Could not find Gem binary (try setting $GEM_BINARY): %s", err.Error())
 	}
 	builder.GemCmd = gemCmd
 	builder.GemVersion = gemVersion

diff --git a/builders/sbt.go b/builders/sbt.go
@@ -55,7 +55,7 @@ func (builder *SBTBuilder) Initialize() error {
 	// Set Java context variables
 	javaCmd, javaVersion, err := which("-version", os.Getenv("JAVA_BINARY"), "java")
 	if err != nil {
-		return fmt.Errorf("could not find Java binary (try setting $JAVA_BINARY): %s", err.Error())
+		sbtLogger.Warningf("Could not find Java binary (try setting $JAVA_BINARY): %s", err.Error())
 	}
 	builder.JavaCmd = javaCmd
 	builder.JavaVersion = javaVersion