refactor(errors): Use errors.New instead of fmt.Errorf when there is …

…no format string

build/archive.go

@@ -4,7 +4,7 @@ import (
 	"archive/tar"
 	"compress/gzip"
 	"encoding/json"
-	"fmt"
+	"errors"
 	"io"
 	"os"
 	"path/filepath"
@@ -38,7 +38,7 @@ func findNodePkgs(path string) []string {
 
 // Build does nothing for VendoredArchives
 func (builder *VendoredArchiveBuilder) Build(m module.Module, force bool) error {
-	return fmt.Errorf("VendoredArchive packages are expected to be pre-built")
+	return errors.New("VendoredArchive packages are expected to be pre-built")
 }
 
 // Analyze scans for archives and inspects them
@@ -119,10 +119,12 @@ func (builder *VendoredArchiveBuilder) IsBuilt(m module.Module, allowUnresolved
 	return true, nil
 }
 
+// IsModule is not implemented
 func (builder *VendoredArchiveBuilder) IsModule(target string) (bool, error) {
-	return false, fmt.Errorf("IsModule is not implemented for VendoredArchiveBuilder")
+	return false, errors.New("IsModule is not implemented for VendoredArchiveBuilder")
 }
 
+// InferModule is not implemented
 func (builder *VendoredArchiveBuilder) InferModule(target string) (module.Module, error) {
-	return module.Module{}, fmt.Errorf("InferModule is not implemented for VendoredArchiveBuilder")
+	return module.Module{}, errors.New("InferModule is not implemented for VendoredArchiveBuilder")
 }

build/bower.go

@@ -1,6 +1,7 @@
 package build
 
 import (
+	"errors"
 	"fmt"
 	"os"
 	"path/filepath"
@@ -137,10 +138,10 @@ func (builder *BowerBuilder) IsBuilt(m module.Module, allowUnresolved bool) (boo
 
 // IsModule is not implemented
 func (builder *BowerBuilder) IsModule(target string) (bool, error) {
-	return false, fmt.Errorf("IsModule is not implemented for BowerBuilder")
+	return false, errors.New("IsModule is not implemented for BowerBuilder")
 }
 
 // InferModule is not implemented
 func (builder *BowerBuilder) InferModule(target string) (module.Module, error) {
-	return module.Module{}, fmt.Errorf("InferModule is not implemented for BowerBuilder")
+	return module.Module{}, errors.New("InferModule is not implemented for BowerBuilder")
 }

build/common.go

@@ -3,6 +3,7 @@ package build
 import (
 	"bytes"
 	"encoding/json"
+	"errors"
 	"fmt"
 	"io/ioutil"
 	"os"
@@ -125,7 +126,7 @@ func whichWithResolver(cmds []string, getVersion versionResolver) (string, strin
 		}
 		commonLogger.Debugf("Tried resolving `%s` but did not work: %#v %#v", cmd, err, version)
 	}
-	return "", "", fmt.Errorf("could not resolve version")
+	return "", "", errors.New("could not resolve version")
 }
 
 func which(versionFlags string, cmds ...string) (string, string, error) {

build/composer.go

@@ -2,6 +2,7 @@ package build
 
 import (
 	"encoding/json"
+	"errors"
 	"fmt"
 	"os"
 	"strings"
@@ -133,10 +134,10 @@ func (builder *ComposerBuilder) IsBuilt(m module.Module, allowUnresolved bool) (
 
 // IsModule is not implemented
 func (builder *ComposerBuilder) IsModule(target string) (bool, error) {
-	return false, fmt.Errorf("IsModule is not implemented for ComposerBuilder")
+	return false, errors.New("IsModule is not implemented for ComposerBuilder")
 }
 
 // InferModule is not implemented
 func (builder *ComposerBuilder) InferModule(target string) (module.Module, error) {
-	return module.Module{}, fmt.Errorf("InferModule is not implemented for ComposerBuilder")
+	return module.Module{}, errors.New("InferModule is not implemented for ComposerBuilder")
 }

build/golang.go

@@ -1,6 +1,7 @@
 package build
 
 import (
+	"errors"
 	"fmt"
 	"io/ioutil"
 	"os"
@@ -199,7 +200,7 @@ func (builder *GoBuilder) Build(m module.Module, force bool) error {
 		return fmt.Errorf("could not find Go project folder: %s", err.Error())
 	}
 	if !ok {
-		return fmt.Errorf("could not find Go project folder (maybe your Go build tool is not supported?)")
+		return errors.New("could not find Go project folder (maybe your Go build tool is not supported?)")
 	}
 	goLogger.Debugf("Found project folder for Go build: %#v", projectFolder)
 
@@ -255,13 +256,13 @@ func traceImports(m module.Module, allowUnresolved bool) ([]GoPkg, error) {
 	var tree depth.Tree
 	err := tree.Resolve(m.Target)
 	if err != nil {
-		return nil, fmt.Errorf("could not resolve dependencies: " + err.Error())
+		return nil, fmt.Errorf("could not resolve dependencies: %s", err.Error())
 	}
 
 	// Flatten tree (technically a DAG?) into a list.
 	deps, err := flattenGoDeps(*tree.Root, allowUnresolved)
 	if err != nil {
-		return nil, fmt.Errorf("could not resolve dependencies: " + err.Error())
+		return nil, fmt.Errorf("could not resolve dependencies: %s", err.Error())
 	}
 
 	return deps, nil
@@ -274,7 +275,7 @@ func flattenGoDeps(pkg depth.Pkg, allowUnresolved bool) ([]GoPkg, error) {
 		if len(pkg.Deps) == 0 {
 			return []GoPkg{GoPkg{ImportPath: pkg.Name, isInternal: pkg.Internal}}, nil
 		}
-		return nil, fmt.Errorf("dependency of stdlib detected (this should never happen)")
+		return nil, errors.New("dependency of stdlib detected (this should never happen)")
 	}
 
 	// Get recursively flattened trees of child dependencies.
@@ -293,7 +294,7 @@ func flattenGoDeps(pkg depth.Pkg, allowUnresolved bool) ([]GoPkg, error) {
 	}
 
 	// Otherwise, fail.
-	return nil, fmt.Errorf("could not resolve package: " + pkg.Name)
+	return nil, fmt.Errorf("could not resolve package: %s", pkg.Name)
 }
 
 // Lockfile structs for JSON unmarshalling
@@ -373,7 +374,7 @@ func (builder *GoBuilder) Analyze(m module.Module, allowUnresolved bool) ([]modu
 			}
 			return deps, err
 		}
-		return nil, fmt.Errorf("could not find project folder")
+		return nil, errors.New("could not find project folder")
 	}
 	goLogger.Debugf("Found project folder: %#v", projectFolder)
 
@@ -435,9 +436,11 @@ func (builder *GoBuilder) Analyze(m module.Module, allowUnresolved bool) ([]modu
 	if ok, err := hasVndrManifest(projectFolder); err == nil && ok {
 		goLogger.Debugf("Found Vndr manifest")
 
-		lockfileContents, err := ioutil.ReadFile(filepath.Join(projectFolder, "vendor.conf"))
+		lockfile := filepath.Join(projectFolder, "vendor.conf")
+		lockfileContents, err := ioutil.ReadFile(lockfile)
 		if err != nil {
-			return nil, fmt.Errorf("could not read vendor.conf")
+			goLogger.Debugf("Error reading %s: %s", lockfile, err.Error())
+			return nil, fmt.Errorf("could not read %s: %s", lockfile, err.Error())
 		}
 
 		lines := strings.Split(string(lockfileContents), "\n")
@@ -544,10 +547,10 @@ func (builder *GoBuilder) IsBuilt(m module.Module, allowUnresolved bool) (bool,
 
 // IsModule is not implemented
 func (builder *GoBuilder) IsModule(target string) (bool, error) {
-	return false, fmt.Errorf("IsModule is not implemented for GoBuilder")
+	return false, errors.New("IsModule is not implemented for GoBuilder")
 }
 
 // InferModule is not implemented
 func (builder *GoBuilder) InferModule(target string) (module.Module, error) {
-	return module.Module{}, fmt.Errorf("InferModule is not implemented for GoBuilder")
+	return module.Module{}, errors.New("InferModule is not implemented for GoBuilder")
 }

build/maven.go

@@ -1,6 +1,7 @@
 package build
 
 import (
+	"errors"
 	"fmt"
 	"os"
 	"regexp"
@@ -134,10 +135,10 @@ func (builder *MavenBuilder) IsBuilt(m module.Module, allowUnresolved bool) (boo
 
 // IsModule is not implemented
 func (builder *MavenBuilder) IsModule(target string) (bool, error) {
-	return false, fmt.Errorf("IsModule is not implemented for MavenBuilder")
+	return false, errors.New("IsModule is not implemented for MavenBuilder")
 }
 
 // InferModule is not implemented
 func (builder *MavenBuilder) InferModule(target string) (module.Module, error) {
-	return module.Module{}, fmt.Errorf("InferModule is not implemented for MavenBuilder")
+	return module.Module{}, errors.New("InferModule is not implemented for MavenBuilder")
 }

build/nodejs.go

@@ -1,6 +1,7 @@
 package build
 
 import (
+	"errors"
 	"fmt"
 	"os"
 	"path/filepath"
@@ -156,10 +157,10 @@ func (builder *NodeJSBuilder) IsBuilt(m module.Module, allowUnresolved bool) (bo
 
 // IsModule is not implemented
 func (builder *NodeJSBuilder) IsModule(target string) (bool, error) {
-	return false, fmt.Errorf("IsModule is not implemented for NodeJSBuilder")
+	return false, errors.New("IsModule is not implemented for NodeJSBuilder")
 }
 
 // InferModule is not implemented
 func (builder *NodeJSBuilder) InferModule(target string) (module.Module, error) {
-	return module.Module{}, fmt.Errorf("InferModule is not implemented for NodeJSBuilder")
+	return module.Module{}, errors.New("InferModule is not implemented for NodeJSBuilder")
 }

build/ruby.go

@@ -1,6 +1,7 @@
 package build
 
 import (
+	"errors"
 	"fmt"
 	"os"
 	"regexp"
@@ -144,10 +145,10 @@ func (builder *RubyBuilder) IsBuilt(m module.Module, allowUnresolved bool) (bool
 
 // IsModule is not implemented
 func (builder *RubyBuilder) IsModule(target string) (bool, error) {
-	return false, fmt.Errorf("IsModule is not implemented for RubyBuilder")
+	return false, errors.New("IsModule is not implemented for RubyBuilder")
 }
 
 // InferModule is not implemented
 func (builder *RubyBuilder) InferModule(target string) (module.Module, error) {
-	return module.Module{}, fmt.Errorf("InferModule is not implemented for RubyBuilder")
+	return module.Module{}, errors.New("InferModule is not implemented for RubyBuilder")
 }