Container Scanning: Adds Os Release Information Parsers #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spatten
approved these changes
Jul 27, 2022
There was a problem hiding this comment.
This looks good to me, but only as someone who hasn't written a parser yet. If you want to get a more nuanced review you might want to ask someone else to take a quick look.
One general question is were you able to test this against an actual /bin/busybox binary? If you did, can you add the steps to do that in a testing plan.
jssblck
approved these changes
Jul 27, 2022
Comment on lines
+156
to
+159
| asum | ||
| ( map (`Map.lookup` properties) ["ID"] | ||
| ++ [Just "linux"] -- We should default to linux as last resort per spec! | ||
| ) |
Comment on lines
+168
to
+171
| -- >> parseTest propertiesParser "A=B\nC=D" = fromList [(A, B), (C, D)] | ||
| -- >> parseTest propertiesParser "A=B\n\nC=D" = fromList [(A, B), (C, D)] | ||
| propertiesParser :: Parser (Map.Map Text Text) | ||
| propertiesParser = Map.fromList <$> many (lexeme propertyParser) |
There was a problem hiding this comment.
I like these inline comments showing what these functions concretely do!
Co-authored-by: Jessica Black <kit@kitified.dev>
meghfossa
force-pushed
the
feat/container-scanning/adds-os-release
branch
from
8b1b97f
to
4971539
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds Os Release parser as part of container scanning scaffolding works.
Acceptance criteria
Testing plan
I have added unit tests. As native container scanning is not configured E/E it cannot be tested manually yet.
Risks
N/A
References
https://fossa.atlassian.net/browse/ANE-284
Checklist
docs/.Changelog.md. If this PR did not mark a release, I added my changes into an# Unreleasedsection at the top..fossa.ymlorfossa-deps.{json.yml}, I updateddocs/references/files/*.schema.json. You may also need to update these if you have added/removed new dependency type (e.g.pip) or analysis target type (e.g.poetry).