-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update manual dependencies docs #1030
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Changelog.md
Outdated
@@ -1,5 +1,9 @@ | |||
# FOSSA CLI Changelog | |||
|
|||
## Unreleased | |||
|
|||
- Fix a bug in fossa-deps.schema.json. It is now valid JSON. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add the PR link to the end of the line.
| [haskell-language-server][hls] ("HLS") | LSP server for haskell projects | | ||
| [hlint][hlint] | A linting + hints tool for haskell code. It provides really useful suggestions. `hlint` is bundled with HLS | | ||
| [fourmolu][fourmolu] | A haskell source code formatter. `fourmolu` is bundled with HLS | | ||
| name | description | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
I think that there were two discrepancies: swift was not mentioned in the docs, and bower was not included in the schema. I updated both of these in the PR. I think that fixes the problem. I've just looked again, and I think the two lists match. Did I miss something? |
@spatten you are correct, it was fixed properly, sorry for the noise. |
No problem at all! Thanks for flagging this in the Issue :) |
Overview
closes #1027
Acceptance criteria
Testing plan
I tested that the linter caught an invalid schema by reverting the fix to the schema and checking that the linter failed.
Everything else is a documentation fix.
Risks
None
References
Checklist
docs/
.Changelog.md
. If this PR did not mark a release, I added my changes into an# Unreleased
section at the top..fossa.yml
orfossa-deps.{json.yml}
, I updateddocs/references/files/*.schema.json
. You may also need to update these if you have added/removed new dependency type (e.g.pip
) or analysis target type (e.g.poetry
).