Support project labels #1145
Merged
Support project labels #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zlav
force-pushed
the
feat/project-labels
branch
from
09564ba
to
77b78c7
Compare
csasarak
approved these changes
Feb 2, 2023
| @@ -517,6 +517,7 @@ collectScanDestination maybeCfgFile envvars AnalyzeCliOpts{..} = | |||
| else do | |||
| apiOpts <- collectApiOpts maybeCfgFile envvars commons | |||
| let metaMerged = maybe analyzeMetadata (mergeFileCmdMetadata analyzeMetadata) (maybeCfgFile) | |||
| when (length (projectLabel metaMerged) > 5) $ fatalText "Projects are only allowed to have 5 associated project labels" | |||
There was a problem hiding this comment.
Is it possible to add a unit test for the failure on > 5 behavior?
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The CLI should be able to handle a new “label” option which will allow a string parameter with the label name. Up to 5 label options can be provided. This data will be accepted by the CLI upload route.
The CLI route accepts an array of strings as a query param “labels”.
Acceptance criteria
Testing plan
The route is already supported on FOSSA cloud, so testing this was as easy as enabling labels and ensuring that the correct behavior was met when setting a
--project-labelflag.References
Checklist
docs/.Changelog.md. If this PR did not mark a release, I added my changes into an# Unreleasedsection at the top..fossa.ymlorfossa-deps.{json.yml}, I updateddocs/references/files/*.schema.json. You may also need to update these if you have added/removed new dependency type (e.g.pip) or analysis target type (e.g.poetry).