-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ANE-1166] Support lock-file v6 for pnpm
#1320
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meghfossa
force-pushed
the
feat/pnpm-lock-v6
branch
from
November 8, 2023 05:34
3ffff01
to
a57f4ef
Compare
jssblck
requested changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The v4/v7 handling is the only hard blocker here unless there's good reason for it working the way it does (or I'm misunderstanding).
meghfossa
force-pushed
the
feat/pnpm-lock-v6
branch
from
November 13, 2023 20:58
f33ce19
to
3b93211
Compare
meghfossa
commented
Nov 13, 2023
jssblck
approved these changes
Nov 15, 2023
meghfossa
force-pushed
the
feat/pnpm-lock-v6
branch
from
November 15, 2023 20:24
26204b4
to
0fd0c63
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR,
pnpm
lock-file:6.0
, which is default format with pnpm8.x
.Sibling PR: fossas/example-projects#10
Acceptance criteria
As a user,
pnpm
project using lock-file, with6.0
pnpm
workspace project using lock-file, with6.0
Testing plan
I added automated tests.
fossa analyze -o
against anypnpm
project using8.x
For example,
Let's take popular project:
There is also example: https://fossa.atlassian.net/browse/ANE-1166
Risks
N/A
Metrics
N/A
References
https://fossa.atlassian.net/browse/ANE-1166
Checklist
docs/
.Changelog.md
. If this PR did not mark a release, I added my changes into an# Unreleased
section at the top..fossa.yml
orfossa-deps.{json.yml}
, I updateddocs/references/files/*.schema.json
. You may also need to update these if you have added/removed new dependency type (e.g.pip
) or analysis target type (e.g.poetry
).docs/references/subcommands/<subcommand>.md
.