Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No Ticket]: Change GitHub actions to use macos-12 #1419

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

JeffreyHuynh1
Copy link
Contributor

@JeffreyHuynh1 JeffreyHuynh1 commented Apr 26, 2024

Overview

Previously we were using macos-latest for our macos runners. However, there are migrations to use ARM instead of AMD for macos-latest.

It has caused this test to fail:

You can see that github has updated macos-latest here:

Changing to macos-12 to be conservative and based on the suggestion here:

Testing plan

  • Test via GH actions

Risks

Metrics

References

Checklist

  • I added tests for this PR's change (or explained in the PR description why tests don't make sense).
  • If this PR introduced a user-visible change, I added documentation into docs/.
  • If this PR added docs, I added links as appropriate to the user manual's ToC in docs/README.ms and gave consideration to how discoverable or not my documentation is.
  • If this change is externally visible, I updated Changelog.md. If this PR did not mark a release, I added my changes into an # Unreleased section at the top.
  • If I made changes to .fossa.yml or fossa-deps.{json.yml}, I updated docs/references/files/*.schema.json AND I have updated example files used by fossa init command. You may also need to update these if you have added/removed new dependency type (e.g. pip) or analysis target type (e.g. poetry).
  • If I made changes to a subcommand's options, I updated docs/references/subcommands/<subcommand>.md.

@JeffreyHuynh1 JeffreyHuynh1 changed the title [No Ticket]: Change install script to use macos-13 [No Ticket]: Change install script to use macos-12 Apr 26, 2024
@JeffreyHuynh1 JeffreyHuynh1 marked this pull request as ready for review April 26, 2024 20:43
@JeffreyHuynh1 JeffreyHuynh1 requested a review from a team as a code owner April 26, 2024 20:43
@JeffreyHuynh1 JeffreyHuynh1 requested a review from csasarak April 26, 2024 20:43
@JeffreyHuynh1 JeffreyHuynh1 changed the title [No Ticket]: Change install script to use macos-12 [No Ticket]: Change GitHub actions to use macos-12 Apr 26, 2024
Copy link
Contributor

@csasarak csasarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working for me. After merging please download the binaries and test again before cutting a release.

@JeffreyHuynh1 JeffreyHuynh1 merged commit 9c24b80 into master Apr 26, 2024
16 checks passed
@JeffreyHuynh1 JeffreyHuynh1 deleted the github-action-installation-script-fix branch April 26, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants