Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift: Support v3 file format, downgrade version mismatch to warning in the future #1424

Merged
merged 9 commits into from
May 3, 2024

Conversation

jssblck
Copy link
Member

@jssblck jssblck commented May 2, 2024

Overview

Resolves ANE-1739:

  • Downgrades version mismatch in the Package.resolved file to a warning, if parsing otherwise succeeds. If parsing fails because the actual shape of the data changes in a backwards-incompatible way, that will still be an error.
  • Adds explicit support for v3, which is not different from v2 for our purposes.

Acceptance criteria

SwiftPM v3 files can be parsed.

Testing plan

I added an automated test for this and I am relying on that.

Risks

None

Metrics

None

References

Resolves: https://fossa.atlassian.net/browse/ANE-1739

Checklist

  • I added tests for this PR's change (or explained in the PR description why tests don't make sense).
  • If this PR introduced a user-visible change, I added documentation into docs/.
  • If this PR added docs, I added links as appropriate to the user manual's ToC in docs/README.ms and gave consideration to how discoverable or not my documentation is.
  • If this change is externally visible, I updated Changelog.md. If this PR did not mark a release, I added my changes into an # Unreleased section at the top.
  • If I made changes to .fossa.yml or fossa-deps.{json.yml}, I updated docs/references/files/*.schema.json AND I have updated example files used by fossa init command. You may also need to update these if you have added/removed new dependency type (e.g. pip) or analysis target type (e.g. poetry).
  • If I made changes to a subcommand's options, I updated docs/references/subcommands/<subcommand>.md.

@jssblck jssblck marked this pull request as ready for review May 2, 2024 22:27
@jssblck jssblck requested a review from a team as a code owner May 2, 2024 22:27
@jssblck jssblck requested a review from csasarak May 2, 2024 22:27
@jssblck jssblck merged commit 87635a7 into master May 3, 2024
16 checks passed
@jssblck jssblck deleted the fix/ane1739 branch May 3, 2024 19:20
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants