Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include projectId in --json output #1464

Merged
merged 6 commits into from
Sep 3, 2024
Merged

Conversation

spatten
Copy link
Contributor

@spatten spatten commented Aug 30, 2024

Overview

Delivers ANE-2002

When you run fossa analyze --json, we want to also include the full project ID in the output. the project ID is typically just the existing project field with custom+ prepended to it:

fossa analyze --json
{
  "branch": null,
  "id": "custom+24987/ane-1993-missing-preview$2024-08-29T21:53:33Z",
  "project": "24987/ane-1993-missing-preview",
  "projectId": "custom+24987/ane-1993-missing-preview",
  "revision": "2024-08-29T21:53:33Z",
  "url": "https://app.fossa.com/projects/custom%2b24987%2fane-1993-missing-preview/refs/branch/master/2024-08-29T21:53:33Z"
}

Acceptance criteria

When you run fossa analyze --json we include the full projectId in the output

Testing plan

Run fossa analyze --json on a project and take a look at the output

Risks

This is low risk

References

Checklist

  • I added tests for this PR's change (or explained in the PR description why tests don't make sense).
  • If this PR introduced a user-visible change, I added documentation into docs/.
  • If this PR added docs, I added links as appropriate to the user manual's ToC in docs/README.ms and gave consideration to how discoverable or not my documentation is.
  • If this change is externally visible, I updated Changelog.md. If this PR did not mark a release, I added my changes into an # Unreleased section at the top.
  • If I made changes to .fossa.yml or fossa-deps.{json.yml}, I updated docs/references/files/*.schema.json AND I have updated example files used by fossa init command. You may also need to update these if you have added/removed new dependency type (e.g. pip) or analysis target type (e.g. poetry).
  • If I made changes to a subcommand's options, I updated docs/references/subcommands/<subcommand>.md.

@spatten spatten marked this pull request as ready for review August 31, 2024 00:21
@spatten spatten requested a review from a team as a code owner August 31, 2024 00:21
@spatten spatten requested review from zlav and csasarak August 31, 2024 00:21
@spatten spatten enabled auto-merge (squash) September 3, 2024 19:07
@spatten spatten merged commit b1b49c7 into master Sep 3, 2024
18 checks passed
@spatten spatten deleted the project-locator-in-json-output branch September 3, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants