feat(yarn) add yarn lockfile parsing #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Sep 24, 2018
golangcibot
reviewed
Sep 25, 2018
buildtools/yarn/parse_test.go
Outdated
| assert.NotEmpty(t, lockfile) | ||
| } | ||
|
|
||
| var chaiDirectDep = pkg.Import{ |
buildtools/yarn/parse.go
Outdated
| return graph.Deps{}, nil | ||
| } | ||
|
|
||
| func readLockfile(pathElems ...string) (YarnLockfile, error) { |
microsoftly
changed the title
elldritch
approved these changes
Sep 25, 2018
buildtools/yarn/parse.go
Outdated
| ) | ||
|
|
||
| // FromLockfile builds a dependency graph based on the the lockfile found in the provided path | ||
| func FromLockfile(pathElems ...string) (graph.Deps, error) { |
There was a problem hiding this comment.
I'd rather this take both a lockfile path and a manifest path (we probably want to subsequently change the name to something like FromProject).
@zlav has been working on something similar for the Go analyser.
buildtools/yarn/parse.go
Outdated
| } | ||
|
|
||
| // To know which deps are direct, we need the manifest def | ||
| manifestPath := filepath.Join(filepath.Dir(filePath), "package.json") |
There was a problem hiding this comment.
I'd rather take the manifest path as an argument. This function will generally be called on projects (not dependencies) anyway, where it's much more likely that the manifest has a weird name.
| yamlCompatLockfile := r.ReplaceAll(fileContent, []byte(": \"")) | ||
| println(string(fileContent)) | ||
|
|
||
| err = yaml.Unmarshal(yamlCompatLockfile, &lockfile) |
There was a problem hiding this comment.
Neat! I can't believe you actually used this trick and it works. This is great.
meghfossa
pushed a commit
that referenced
this pull request
Nov 12, 2021
* releasegroup support * bump ghc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.