feat(yarn lockfile fallback) add yarn lockfile reading fallback #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Sep 26, 2018
analyzers/nodejs/nodejs.go
Outdated
| Dir: a.Module.Dir, | ||
| }) | ||
| if ok, err := files.Exists(a.Module.Dir, "yarn.lock"); err == nil && ok && a.YarnTool.Exists() { | ||
| a.YarnTool.Install(a.Module.Dir) |
There was a problem hiding this comment.
Error return value of a.YarnTool.Install is not checked
microsoftly
commented
Sep 26, 2018
analyzers/nodejs/nodejs.go
Outdated
| log.Warnf("NPM had non-zero exit code: %s", err.Error()) | ||
| log.Debug("Using fallback of node_modules") | ||
| pkgs, err := a.NPMTool.List(filepath.Dir(a.Module.BuildTarget)) | ||
| if err == nil { |
There was a problem hiding this comment.
restructuring checks for err == nil allows this func to avoid a level of nesting every time we use a fallback
elldritch
approved these changes
Sep 27, 2018
analyzers/nodejs/nodejs.go
Outdated
|
|
||
| YarnCmd string | ||
| YarnVersion string | ||
| NPMTool npm.NPM |
There was a problem hiding this comment.
We can probably just call these NPM and Yarn.
analyzers/nodejs/nodejs.go
Outdated
| @@ -33,10 +34,8 @@ type Analyzer struct { | |||
| NodeCmd string | |||
There was a problem hiding this comment.
Do we still need this now that we have the tools?
analyzers/nodejs/nodejs.go
Outdated
| YarnCmd: yarnCmd, | ||
| YarnVersion: yarnVersion, | ||
| NPMTool: npmTool, | ||
| YarnTool: yarn.New(), |
There was a problem hiding this comment.
We might want to move the os.Getenv checking logic into here, unless anything else uses yarn.New() or npm.New().
meghfossa
pushed a commit
that referenced
this pull request
Nov 12, 2021
… releaseGroupRelease (#293)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also implemented
YarnToolin a similar manner toNPMTool