refactor(codegen): Clean up old code, make codegen consistent #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoftly
reviewed
Sep 28, 2018
| @@ -11,7 +11,7 @@ import ( | |||
| "github.com/fossas/fossa-cli/exec" | |||
| ) | |||
|
|
|||
| //go:generate go-bindata -pkg bindata -o ./bindata/bindata.go ./bindata/pipdeptree.py | |||
| //go:generate go-bindata -pkg bindata -modtime 1 -o ./bindata/bindata.go ./bindata/pipdeptree.py | |||
There was a problem hiding this comment.
what difference does this make?
There was a problem hiding this comment.
git doesn't store modification time. Whenever somebody new checks out the CLI repository, the mtime of the file is the time when they did the checkout.
go-bindata does store modification time (by default). This means every time somebody new checks out the CLI and runs make, it'll produce a diff in this generated file.
By forcing go-bindata to set the mtime to a specific value, new developers no longer need to deal with this extra noise.
There was a problem hiding this comment.
Fan of this change, makes git status a lot more straightforward as well.
zlav
approved these changes
Sep 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.