Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Makefile) update dev-osx to not error out for missing run command #304

Merged
merged 3 commits into from
Oct 1, 2018

Conversation

microsoftly
Copy link
Contributor

Comments cannot be contained within the docker command (which effectively extends to each line with \). Having the comments live inside the command caused docker run to not see fossa/fossa-cli:$(IMAGE) /bin/bash

Copy link
Contributor

@elldritch elldritch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[NIT] Move the comment above the command.

@coveralls
Copy link

coveralls commented Oct 1, 2018

Coverage Status

Coverage remained the same at 35.631% when pulling 132d5dd on fix/makefileOsx into 4e1af41 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants