test(nodejs): Add tests for checking import graphs #337
Conversation
Codecov Report
@@ Coverage Diff @@
## master #337 +/- ##
=======================================
Coverage 41.67% 41.67%
=======================================
Files 58 58
Lines 2644 2644
=======================================
Hits 1102 1102
Misses 1433 1433
Partials 109 109Continue to review full report at Codecov.
|
analyzers/nodejs/nodejs_test.go
Outdated
| @@ -13,6 +13,46 @@ import ( | |||
| "github.com/fossas/fossa-cli/pkg" | |||
| ) | |||
|
|
|||
| // testNDepsTransitiveImports checks that Analyze() returns the correct transitive deps | |||
| // by asserting on transitive dependencies | |||
| func testNDepsTransitiveImports(t *testing.T) { | |||
There was a problem hiding this comment.
testNDepsTransitiveImports is unused
analyzers/nodejs/nodejs_test.go
Outdated
| assertImport(t, chaiProject.Imports, "type-detect", "4.0.8") | ||
| } | ||
|
|
||
| func assertPackageReturnImports(t *testing.T, packages map[pkg.ID]pkg.Package, name, revision string) pkg.Package { |
There was a problem hiding this comment.
func assertPackageReturnImports is unused
analyzers/nodejs/nodejs_test.go
Outdated
| // graph.Deps object by asserting on direct and transitive dependencies | ||
| func TestNodeAnalyze(t *testing.T) { | ||
| m := module.Module{ | ||
| Dir: filepath.Join("testdata", "normal"), |
There was a problem hiding this comment.
Technically this is incorrect. A BuildTarget should be provided. This passes because NPM.List is mocked. You could potentially use a single mock and point to a different mock output based on the BuildTarget provided
analyzers/nodejs/nodejs_test.go
Outdated
| @@ -13,6 +13,50 @@ import ( | |||
| "github.com/fossas/fossa-cli/pkg" | |||
| ) | |||
|
|
|||
| // TestNodeAnalyze checks that Analyze() runs correctly and returns the correct | |||
| // graph.Deps object by asserting on direct and transitive dependencies | |||
| func TestNodeAnalyze(t *testing.T) { | |||
There was a problem hiding this comment.
it would be helpful to add a comment with the actual output of npm ls so it's human readable
elldritch
changed the title
analyzers/nodejs/nodejs_test.go
Outdated
| @@ -13,6 +13,76 @@ import ( | |||
| "github.com/fossas/fossa-cli/pkg" | |||
| ) | |||
|
|
|||
| /* | |||
| { | |||
There was a problem hiding this comment.
Update this to be in a human readable form
e.g.
/*
├─┬ chai@4.1.2
│ ├── assertion-error@1.1.0
│ ├── check-error@1.0.2
│ ├─┬ deep-eql@3.0.1
│ │ └── type-detect@4.0.8
│ ├── get-func-name@2.0.0
│ ├── pathval@1.1.0
│ └── type-detect@4.0.8
└── type-detect@3.0.0
*/
|
@microsoftly the format for |
|
@liftM I confirmed the tests fail for the previous analysis that contained the bug we fixed. Merging this commit now. |
Created from issue [#329]
I added a folder called
normal, welcom to hear name changes but this is normal operation for nodejs analyzation. This holds the node modules and package for the analyzer to grab information from.I also privitized a previous function called
AssertImportwhich was only used in this package and moved it to the end of the file. Github didn't notice this and that is the reason for the large delta at the end of the file.