fix(python) Add options support to requirements.txt parsing #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #370 +/- ##
==========================================
+ Coverage 46.83% 46.89% +0.06%
==========================================
Files 67 67
Lines 3094 3094
==========================================
+ Hits 1449 1451 +2
+ Misses 1496 1495 -1
+ Partials 149 148 -1
Continue to review full report at Codecov.
|
elldritch
approved these changes
Nov 1, 2018
|
[nit] I would call this PR "Add options support to requirements.txt parsing" |
zlav
changed the title
meghfossa
pushed a commit
that referenced
this pull request
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The requirements.txt parser does not currently acknowledge options or file references as distinct information. It uploads them as dependencies causing a missing dependency on the backend. This fixes that issue.
Requirements.txt spec