Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add one-liner install script #83

Merged
merged 3 commits into from
Mar 3, 2018
Merged

Add one-liner install script #83

merged 3 commits into from
Mar 3, 2018

Conversation

elldritch
Copy link
Member

This installation script fixes a number of defects from the jpillora one:

  • We actually control it.
  • It does actual checksum validation.
  • It doesn't require a bunch of extra non-POSIX stuff for archive formats we never use.
  • It correctly extracts and moves the built binary instead of guessing.

@elldritch elldritch requested a review from xizhao March 3, 2018 03:13
xizhao
xizhao approved these changes Mar 3, 2018
View reviewed changes
Copy link
Contributor

@xizhao xizhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for doing this

@xizhao xizhao merged commit db9710b into master Mar 3, 2018
@elldritch elldritch deleted the feat/install-script branch March 3, 2018 03:35
meghfossa pushed a commit that referenced this pull request Nov 12, 2021
Use better types from the CLI handlers to the internals. (#83)
1fad93e 
* Wrap api key and project revision using newtypes

* Format part of main, fix <$$>

* Deduplicate the build/issue flow (#84)

* Implement 80/20 spec analyzer (#79)

* Implement 80/20 spec analyzer

* Add RPM spec docs

* run formatter

* PR fixes + add requires

* Find more files, add type sigs

* remove requires from output, no labels

* mark strategy as optimal

* Simplify buildGraph

* Use Diagnostics vs Error

* Add graphing test

* Deduplicate the build/issue flow

* Rename module

* Fix cabal module name

* Fix imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xizhao xizhao xizhao approved these changes

@lackstein lackstein lackstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elldritch @lackstein @xizhao