Skip to content
This repository has been archived by the owner on Apr 1, 2022. It is now read-only.

Allow fossa vps analyze metadata #149

Merged
merged 3 commits into from
Oct 30, 2020
Merged

Allow fossa vps analyze metadata #149

merged 3 commits into from
Oct 30, 2020

Conversation

skilly-lily
Copy link
Contributor

@skilly-lily skilly-lily commented Oct 27, 2020 •
edited
Loading

Doc changes will be added soon.

  • Separate App.Types.UploadInfo out of ScanDestination
  • Move ProjectMetadata to common types module.
  • Move title || projectName logic to core, simplify CLI logic. (See note)
  • Add metadata opts to command-line. Flow those opts through API.

NOTE: it is unsafe to merge this until fossas/FOSSA#5147 is merged.

@skilly-lily
Allow vps analyze metadata
8fbc164 
Signed-off-by: Wesley Van Melle <van.melle.wes@gmail.com>
@skilly-lily
refactor upload info
8824411 
Signed-off-by: Wesley Van Melle <van.melle.wes@gmail.com>
@skilly-lily
Lost the fixme comments somehow
1c32572 
Signed-off-by: Wesley Van Melle <van.melle.wes@gmail.com>
cnr
cnr approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@cnr cnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those FIXMEs are definitely starting to pile up in App.Fossa.VPS.Types.. otherwise this looks great

@jssblck jssblck removed their request for review October 29, 2020 16:30
@skilly-lily skilly-lily merged commit 686069b into master Oct 30, 2020
@skilly-lily skilly-lily deleted the vps-analyze-metadata branch November 18, 2020 18:44
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cnr cnr cnr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skilly-lily @cnr