Skip to content

Commit

Permalink
Mobile View of reactions partly off-screen when translation option is…
Browse files Browse the repository at this point in the history
… active (#212)

* Only show audio translation option if available

* shrink reaction bar

* update css for reaction bar

* shrink emoji bar

* move reaction bar to left side

* update size for emoji icon

* disable expand action for reation bar

---------

Co-authored-by: Tri Truong <tmtri@tma.com.vn>
Co-authored-by: Mario Behling <mb@mariobehling.de>
  • Loading branch information
3 people authored Aug 12, 2024
1 parent a33ab54 commit 64f619f
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 9 deletions.
12 changes: 8 additions & 4 deletions webapp/src/components/AudioTranslationDropdown.vue
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<template lang="pug">
div.c-audio-translation
h4 Audio Translation
bunt-select(
name="audio-translation",
v-model="selectedLanguage",
Expand Down Expand Up @@ -43,11 +42,16 @@ export default {

<style scoped>
.c-audio-translation {
margin-bottom: 3em;
height: 65px;
padding-top: 3px;
margin-right: 5px;
}
.c-audio-translation h4 {
margin-bottom: 0.5em;
@media (max-width: 992px) {
.c-audio-translation {
width: 50%;
margin-right: 5px;
}
}
.bunt-select {
Expand Down
15 changes: 12 additions & 3 deletions webapp/src/components/ReactionsBar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,10 @@ export default {
<style lang="stylus">
.c-reactions-bar
position: relative
width: 64px
margin-left: 10px
height: 56px
+above('m')
right: 160px
.actions
position: absolute
bottom: 5px
Expand All @@ -54,19 +56,26 @@ export default {
transition: transform .3s ease
.bunt-icon-button
icon-button-style()
height: 27px !important
width: 27px !important
&:not(:first-child)
margin-left: 8px
.emoji
height: 28px
height: 26px
width: @height
display: inline-block
&:not(.expanded)
width: 40px
+below('m')
left: -150px
.actions:hover
cursor: pointer
background-color: $clr-grey-100
.bunt-icon-button
pointer-events: none
&.expanded
.actions
transform: translateX(calc(64px - 100% - 16px))
transform: translateX(calc(50px - 21% - 15px));
+above('m')
transform: translateX(calc(50px - 21% - 50px));
</style>
5 changes: 3 additions & 2 deletions webapp/src/views/rooms/item.vue
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,8 @@
reactions-overlay(v-if="modules['livestream.native'] || modules['livestream.youtube'] || modules['livestream.iframe'] || modules['call.janus']")
.stage-tool-blocker(v-if="activeStageTool !== null", @click="activeStageTool = null")
.stage-tools(v-if="modules['livestream.native'] || modules['livestream.youtube'] || modules['livestream.iframe'] || modules['call.janus']")
reactions-bar(:expanded="true", @expand="activeStageTool = 'reaction'")
//- reactions-bar(:expanded="activeStageTool === 'reaction'", @expand="activeStageTool = 'reaction'")
// Added dropdown menu for audio translations near the reactions bar
reactions-bar(:expanded="true", @expand="activeStageTool = 'reaction'")
AudioTranslationDropdown(v-if="languages.length > 1", :languages="languages", @languageChanged="handleLanguageChange")
media-source-placeholder(v-else-if="modules['call.bigbluebutton'] || modules['call.zoom']")
roulette(v-else-if="modules['networking.roulette'] && $features.enabled('roulette')", :module="modules['networking.roulette']", :room="room")
Expand Down Expand Up @@ -173,6 +172,8 @@ export default {
height: 2px
width: calc(100% - 16px)
background-color: var(--clr-primary)
+below('m')
justify-content: space-between
.stage-tool-blocker
position: fixed
top: 0
Expand Down

0 comments on commit 64f619f

Please sign in to comment.