Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance Chat Mentions #156

Merged
merged 4 commits into from
Jul 21, 2024
Merged

Enhance Chat Mentions #156

merged 4 commits into from
Jul 21, 2024

Conversation

odkhang
Copy link
Collaborator

@odkhang odkhang commented Jul 16, 2024

Fixes #138 Enhance Chat Mentions

Short description of what this resolves:

Implement @username mentions in the chat

Changes proposed in this pull request:

  • Implement @username mentions in the chat

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@odkhang odkhang requested a review from mariobehling July 16, 2024 10:36
@odkhang odkhang marked this pull request as ready for review July 17, 2024 01:10
@mariobehling mariobehling requested a review from hongquan July 17, 2024 07:16
hongquan
hongquan requested changes Jul 17, 2024
View reviewed changes
server/tests/live/test_auth.py Outdated
@@ -1062,3 +1073,4 @@ async def test_anonymous_invite(client, world, stream_room, bbb_room):
"room:poll.vote",
"room:poll.read",
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please configure your editor to automatically clean trailing whitespaces (at the end of line).

server/tests/live/test_chat.py Outdated
@@ -1324,3 +1324,4 @@ async def test_force_join_after_login(world, chat_room):
r = await c2.receive_json_from()
assert r[0] == "chat.channels"
assert channel_id in [c["id"] for c in r[1]["channels"]]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean trailing whitespaces, too.

server/tests/live/test_chat_direct.py Show resolved Hide resolved
hongquan
hongquan reviewed Jul 17, 2024
View reviewed changes
server/venueless/core/migrations/0065_alter_auditlog_data_alter_chatevent_content_and_more.py Outdated

operations = [
migrations.AlterField(
model_name="auditlog",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there migrations relatd to AuditLog model? I don't see changes of AuditLog model in this PR.

@odkhang
Copy link
Collaborator Author

odkhang commented Jul 18, 2024

Hi @hongquan,
I removed unintended changes in the AuditLog model by deleting the incorrect migration file and regenerating the migrations. Now, the new migration file only includes the intended updates.
Please review the updated migrations.

@odkhang odkhang requested a review from hongquan July 19, 2024 01:16
@mariobehling mariobehling merged commit 8b37785 into fossasia:development Jul 21, 2024
1 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongquan hongquan hongquan approved these changes

@mariobehling mariobehling Awaiting requested review from mariobehling

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance Chat Mentions
3 participants
@odkhang @hongquan @mariobehling