Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and enhance branding by renaming eventyay-video #157

Merged

Conversation

odkhang
Copy link
Collaborator

@odkhang odkhang commented Jul 18, 2024

Due to the renaming of the Eventyay-Talk-Video plugin, it is necessary to update the configuration and branding within the Eventyay Video repository.

For reference, please see the related pull request on the Eventyay-Talk-Video repository: Eventyay-Talk-Video PR #2.

Summary by Sourcery

This pull request updates the branding and configuration references in the admin schedule view to reflect the renaming of the Eventyay-Talk-Video plugin to Eventyay-Video.

  • Enhancements:
    • Updated the branding and configuration references from 'venueless' to 'eventyay-video' in the admin schedule view.

@odkhang odkhang requested a review from mariobehling July 18, 2024 09:30
@odkhang odkhang marked this pull request as ready for review July 18, 2024 09:37
Copy link

sourcery-ai bot commented Jul 18, 2024

Reviewer's Guide by Sourcery

This pull request updates the Eventyay Video repository to reflect the renaming of the Eventyay-Talk-Video plugin to Eventyay-Video. The changes primarily involve updating URLs in the configuration and branding within the admin schedule view.

File-Level Changes

Files Changes
webapp/src/views/admin/config/schedule.vue Updated URLs to reflect the renaming of the Eventyay-Talk-Video plugin to Eventyay-Video.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @odkhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@odkhang
Copy link
Collaborator Author

odkhang commented Jul 18, 2024

@mariobehling Could you please help review and merge this PR?

@mariobehling mariobehling merged commit d29c5d8 into fossasia:development Jul 20, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants