Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a link from session to video room #161

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

lcduong
Copy link
Contributor

@lcduong lcduong commented Jul 22, 2024

Fixes #151 Have a link from session to video room

Short description of what this resolves:

Have a link from session to video room

Changes proposed in this pull request:

  • Implement a new button in session info, link to room

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Summary by Sourcery

This pull request introduces a new feature that adds a button in the session info view, allowing users to join the corresponding video room directly. It also enhances the session component by integrating Vuex state to access room information.

  • New Features:
    • Added a button in the session info view that links to the corresponding video room.
  • Enhancements:
    • Integrated Vuex state to access room information for linking sessions to video rooms.

@lcduong
Copy link
Contributor Author

lcduong commented Jul 22, 2024

New button 'JOIN ROOM' allow user to redirect to room,

NOTE: Ensure that the room name of session (sync from eventyay-talk) same with room name at eventyay-video you want user redirect to

image

@lcduong lcduong marked this pull request as ready for review July 22, 2024 10:07
Copy link

sourcery-ai bot commented Jul 22, 2024

Reviewer's Guide by Sourcery

This pull request adds a new button to the session info section that links directly to the video room. The implementation involves importing mapState from vuex to access the rooms state, adding a new computed property for rooms, and creating a method to fetch the room ID by name. Additionally, a new CSS class is added for styling the button.

File-Level Changes

Files Changes
webapp/src/views/schedule/talks/item.vue Implemented a new button in the session info section that links to the video room, including necessary state management and styling changes.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lcduong - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@mariobehling mariobehling requested a review from hongquan July 22, 2024 10:20
@mariobehling
Copy link
Member

Good! We need to test this further also with larger schedules.

@mariobehling mariobehling merged commit 2f21515 into fossasia:development Jul 23, 2024
1 of 2 checks passed
@mariobehling
Copy link
Member

Hi @lcduong this feature does not work smoothly yet. In the test room of @odkhang here the "Join" button disappears during the page loading: https://video-dev.eventyay.com/schedule/talks/RAFUSN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a link from session info redirect to room
2 participants