Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile View of reactions partly off-screen when translation option is active #212

Merged
merged 13 commits into from
Aug 12, 2024
Merged
12 changes: 8 additions & 4 deletions webapp/src/components/AudioTranslationDropdown.vue
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<template lang="pug">
div.c-audio-translation
h4 Audio Translation
bunt-select(
name="audio-translation",
v-model="selectedLanguage",
Expand Down Expand Up @@ -43,11 +42,16 @@ export default {

<style scoped>
.c-audio-translation {
margin-bottom: 3em;
height: 65px;
padding-top: 3px;
margin-right: 5px;
}

.c-audio-translation h4 {
margin-bottom: 0.5em;
@media (max-width: 992px) {
.c-audio-translation {
width: 50%;
margin-right: 5px;
}
}

.bunt-select {
Expand Down
15 changes: 12 additions & 3 deletions webapp/src/components/ReactionsBar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,10 @@ export default {
<style lang="stylus">
.c-reactions-bar
position: relative
width: 64px
margin-left: 10px
height: 56px
+above('m')
right: 160px
.actions
position: absolute
bottom: 5px
Expand All @@ -54,19 +56,26 @@ export default {
transition: transform .3s ease
.bunt-icon-button
icon-button-style()
height: 27px !important
width: 27px !important
&:not(:first-child)
margin-left: 8px
.emoji
height: 28px
height: 26px
width: @height
display: inline-block
&:not(.expanded)
width: 40px
+below('m')
left: -150px
.actions:hover
cursor: pointer
background-color: $clr-grey-100
.bunt-icon-button
pointer-events: none
&.expanded
.actions
transform: translateX(calc(64px - 100% - 16px))
transform: translateX(calc(50px - 21% - 15px));
+above('m')
transform: translateX(calc(50px - 21% - 50px));
</style>
5 changes: 3 additions & 2 deletions webapp/src/views/rooms/item.vue
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,8 @@
reactions-overlay(v-if="modules['livestream.native'] || modules['livestream.youtube'] || modules['livestream.iframe'] || modules['call.janus']")
.stage-tool-blocker(v-if="activeStageTool !== null", @click="activeStageTool = null")
.stage-tools(v-if="modules['livestream.native'] || modules['livestream.youtube'] || modules['livestream.iframe'] || modules['call.janus']")
reactions-bar(:expanded="true", @expand="activeStageTool = 'reaction'")
//- reactions-bar(:expanded="activeStageTool === 'reaction'", @expand="activeStageTool = 'reaction'")
// Added dropdown menu for audio translations near the reactions bar
reactions-bar(:expanded="true", @expand="activeStageTool = 'reaction'")
AudioTranslationDropdown(v-if="languages.length > 1", :languages="languages", @languageChanged="handleLanguageChange")
media-source-placeholder(v-else-if="modules['call.bigbluebutton'] || modules['call.zoom']")
roulette(v-else-if="modules['networking.roulette'] && $features.enabled('roulette')", :module="modules['networking.roulette']", :room="room")
Expand Down Expand Up @@ -173,6 +172,8 @@ export default {
height: 2px
width: calc(100% - 16px)
background-color: var(--clr-primary)
+below('m')
justify-content: space-between
.stage-tool-blocker
position: fixed
top: 0
Expand Down
Loading