-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement timezone feature on schedule/session page similar with Talk systems #243
Conversation
Reviewer's Guide by SourceryThis pull request implements a timezone feature on the schedule/session pages, allowing users to switch between the event timezone and their local timezone. The changes primarily affect the UI and user interaction in the schedule view. User Journey Diagram for Timezone Feature on Schedule/Session Pagejourney
title User Journey for Timezone Selection
section Schedule Page
User selects timezone: 5: User
System displays timezone options: 5: System
User chooses between event timezone and local timezone: 5: User
System updates schedule to reflect selected timezone: 5: System
section Session Page
User views session times in selected timezone: 5: User
System maintains timezone preference across sessions: 5: System
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lcduong - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider extracting the timezone-related logic into a shared component or utility function to reduce code duplication between schedule/sessions/index.vue and schedule/index.vue.
- For better state management, consider using Vuex or a similar solution instead of localStorage for persisting user preferences like timezone selection.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many v-for
are still missing :key
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working as far as I can see.
This PR related to #241, implement timezone select in schedule/session pages
Summary by Sourcery
Implement a timezone selection feature on the schedule and session pages, enabling users to toggle between the event's timezone and their own. Enhance user experience by storing the selected timezone in local storage.
New Features:
Enhancements: