chore(deps-dev): bump ember-cli-template-lint from 0.7.6 to 2.0.0 (#3920

) * chore(deps-dev): bump ember-cli-template-lint from 0.7.6 to 2.0.0 Bumps [ember-cli-template-lint](https://github.com/ember-template-lint/ember-cli-template-lint) from 0.7.6 to 2.0.0. - [Release notes](https://github.com/ember-template-lint/ember-cli-template-lint/releases) - [Changelog](https://github.com/ember-template-lint/ember-cli-template-lint/blob/master/CHANGELOG.md) - [Commits](ember-template-lint/ember-cli-template-lint@v0.7.6...v2.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
fossasia · Jan 31, 2020 · 44d2c5b · 44d2c5b
1 parent 298a636
commit 44d2c5b
Show file tree

Hide file tree

Showing 20 changed files with 406 additions and 118 deletions.
diff --git a/.template-lintrc.js b/.template-lintrc.js
@@ -6,6 +6,14 @@ module.exports = {
   rules: {
     'no-nested-interactive': {
       ignoredTags: ['label'] // Allow label tag inside a or any other interactive element
-    }
+    },
+    'link-rel-noopener': true,
+    // TODO: Remove and fix
+    'require-button-type': false,
+    'no-partial': false,
+    'require-valid-alt-text': false,
+    'no-inline-styles': false,
+    'no-negated-condition': false,
+    'no-invalid-meta': false // Crashing the linter https://github.com/ember-template-lint/ember-template-lint/pull/1087
   }
 };
diff --git a/app/templates/application.hbs b/app/templates/application.hbs
@@ -5,7 +5,7 @@
     <i class="close icon" onclick={{action (mut showCookie) false}} role="button"></i>
     {{model.cookiePolicy}}
     {{#if model.cookiePolicyLink}}
-      <p>For more information <a href="{{model.cookiePolicyLink}}">click here</a>.</p>
+      <p><a href="{{model.cookiePolicyLink}}">Click here For more information</a></p>
     {{/if}}
   </div>
 {{/if}}

diff --git a/app/templates/attendee-app.hbs b/app/templates/attendee-app.hbs
@@ -1,5 +1,5 @@
 <div class='ui secondary pointing menu'>
-  <a class='active item'>
+  <a href="#" class='active item'>
     {{t 'Attendee App'}}
   </a>
 </div>

diff --git a/app/templates/components/account/email-preferences-section.hbs b/app/templates/components/account/email-preferences-section.hbs
@@ -25,7 +25,7 @@
         <h4 class="ui header">{{preference.event.name}}</h4>
       </div>
       <div class="ui column eight wide right aligned">
-        <a class="ui circular label {{if (or preference.newPaper preference.sessionSchedule preference.nextEvent) 'green' 'yellow'}}">
+        <a href="#" class="ui circular label {{if (or preference.newPaper preference.sessionSchedule preference.nextEvent) 'green' 'yellow'}}">
           {{#if (or preference.newPaper preference.sessionSchedule preference.nextEvent)}}
             {{t 'On'}}
           {{else}}

diff --git a/app/templates/components/event-card.hbs b/app/templates/components/event-card.hbs
@@ -53,7 +53,7 @@
             </a>
           {{else}}
             {{#each tags as |tag|}}
-              <a>{{tag}}</a>
+              <a href="#">{{tag}}</a>
             {{/each}}
           {{/if}}
         {{/if}}

diff --git a/app/templates/components/forms/wizard/basic-details-step.hbs b/app/templates/components/forms/wizard/basic-details-step.hbs
@@ -15,7 +15,7 @@
       placeholder=(t 'Location is required to make this event live')}}
       <div class="inline field">
         <div class="ui slider checkbox">
-          {{input id='show_map' type='checkbox' id='show_map' checked=data.event.isMapShown}}
+          {{input id='show_map' type='checkbox' checked=data.event.isMapShown}}
           <label for="show_map">{{t 'Show map on event page'}}</label>
         </div>
       </div>
@@ -389,10 +389,10 @@
           <div class="field">
             {{#if (or data.event.stripeAuthorization.stripeAuthCode data.event.stripeAuthorization.stripePublishableKey)}}
               <label class="required">{{t 'You have linked your Stripe account successfully. Click Here to Disconnect you account.'}}</label>
-              <a class="stripe-connect" role="button" {{action 'disconnectStripe'}}><span>{{t 'Disconnect Stripe Account'}}</span></a>
+              <a href="#" class="stripe-connect" role="button" {{action 'disconnectStripe'}}><span>{{t 'Disconnect Stripe Account'}}</span></a>
             {{else}}
               <label class="required">{{t 'Connect to your Stripe account'}}</label>
-              <a class="stripe-connect" role="button" {{action 'connectStripe'}}><span>{{t 'Connect with Stripe'}}</span></a>
+              <a href="#" class="stripe-connect" role="button" {{action 'connectStripe'}}><span>{{t 'Connect with Stripe'}}</span></a>
             {{/if}}
           </div>
         {{/if}}

diff --git a/app/templates/components/nav-bar.hbs b/app/templates/components/nav-bar.hbs
@@ -26,7 +26,7 @@
               <a href="{{href-to 'admin'}}" class="item">{{t 'Admin'}}</a>
             {{/if}}
             <div class="divider"></div>
-            <a role="button" class="item logout-button" {{action 'logout'}}><span>{{t 'Logout'}}<i class="ui right floated large signout sign out icon"></i></span></a>
+            <a href="#" role="button" class="item logout-button" {{action 'logout'}}><span>{{t 'Logout'}}<i class="ui right floated large signout sign out icon"></i></span></a>
           </div>
         {{/ui-dropdown}}
       {{else}}
@@ -44,7 +44,7 @@
 </div>
 <div class="mobile only row">
   <div class="ui navbar tiny menu">
-    <a class="menu item open sidebar">
+    <a href="#" class="menu item open sidebar">
       <i class="large content icon"></i>
     </a>
     {{#link-to 'index' class='item' activeClass=''}}

diff --git a/app/templates/components/public/call-for-speakers.hbs b/app/templates/components/public/call-for-speakers.hbs
@@ -2,12 +2,12 @@
 <h1 class="ui header">
   {{t 'Call for Speakers'}}
   {{#if data.speakersCall.isOpen}}
-    <a class="ui basic green label">{{t 'Open'}}</a>
+    <a href="#" class="ui basic green label">{{t 'Open'}}</a>
     <div class="sub header">
       {{t 'Call for Speakers is open until'}} {{moment-format data.speakersCall.endsAt 'ddd, MMM DD h:mm A'}}
     </div>
   {{else}}
-    <a class="ui basic red label">{{t 'Closed'}}</a>
+    <a href="#" class="ui basic red label">{{t 'Closed'}}</a>
     <div class="sub header">
       {{#if data.speakersCall.isInFuture}}
         {{t 'Call for Speakers will open at'}} {{moment-format data.speakersCall.startsAt 'ddd, MMM DD h:mm A' }}
@@ -28,7 +28,7 @@
           {{#if session.id}}
             <div class="item">
               {{#link-to 'public.cfs.edit-session' session.id }}
-                <a class="ui very tiny basic blue button">{{session.title}}</a>
+                <a href="#" class="ui very tiny basic blue button">{{session.title}}</a>
               {{/link-to}}
             </div>
           {{/if}}

diff --git a/app/templates/components/public/event-map.hbs b/app/templates/components/public/event-map.hbs
@@ -2,7 +2,7 @@
   <div class="eight wide column event-map">
     <h1>{{t 'Getting Here'}}</h1>
     {{#if (eq mapConfig.display 'embed') }}
-      <iframe class="g-map" src="https://maps.google.com/maps?q={{event.locationName}}&t=&z=15&ie=UTF8&iwloc=&output=embed" frameborder="0" scrolling="no"></iframe>
+      <iframe title="Map" class="g-map" src="https://maps.google.com/maps?q={{event.locationName}}&t=&z=15&ie=UTF8&iwloc=&output=embed" frameborder="0" scrolling="no"></iframe>
     {{else}}
       {{#g-map markersFitMode='live' lat=37.744 lng=-122.4367 address=event.locationName zoom=2 class='google-maps' as |context|}}
         {{#g-map-address-marker context address=event.locationName as |markerContext|}}

diff --git a/app/templates/components/tables/utilities/pagination.hbs b/app/templates/components/tables/utilities/pagination.hbs
@@ -1,14 +1,14 @@
 <div class="ui small pagination menu">
-  <a role="button" class="item {{if moveToPreviousPageDisabled 'disabled'}}" {{action 'moveToFirstPage'}}>
+  <a href="#" role="button" class="item {{if moveToPreviousPageDisabled 'disabled'}}" {{action 'moveToFirstPage'}}>
     <i class="angle double left icon"></i>
   </a>
-  <a role="button" class="item {{if moveToPreviousPageDisabled 'disabled'}}" {{action 'moveToPreviousPage'}}>
+  <a href="#" role="button" class="item {{if moveToPreviousPageDisabled 'disabled'}}" {{action 'moveToPreviousPage'}}>
     <i class="angle left icon"></i>
   </a>
-  <a role="button" class="item {{if moveToNextPageDisabled 'disabled'}}" {{action 'moveToNextPage'}}>
+  <a href="#" role="button" class="item {{if moveToNextPageDisabled 'disabled'}}" {{action 'moveToNextPage'}}>
     <i class="angle right icon"></i>
   </a>
-  <a role="button" class="item {{if moveToNextPageDisabled 'disabled'}}" {{action 'moveToLastPage'}}>
+  <a href="#" role="button" class="item {{if moveToNextPageDisabled 'disabled'}}" {{action 'moveToLastPage'}}>
     <i class="angle double right icon"></i>
   </a>
 </div>

diff --git a/app/templates/components/ui-table/cell/cell-label.hbs b/app/templates/components/ui-table/cell/cell-label.hbs
@@ -1,11 +1,11 @@
 <span>
   {{#if extraRecords.isExpired}}
-    <a class="ui red label">{{t 'Expired'}}</a>
+    <a href="#" class="ui red label">{{t 'Expired'}}</a>
   {{else}}
     {{#if record}}
-      <a class="ui green label">{{t 'Active'}}</a>
+      <a href="#" class="ui green label">{{t 'Active'}}</a>
     {{else}}
-      <a class="ui yellow label">{{t 'Inactive'}}</a>
+      <a href="#" class="ui yellow label">{{t 'Inactive'}}</a>
     {{/if}}
   {{/if}}
 </span>
diff --git a/app/templates/components/ui-table/cell/cell-title-message.hbs b/app/templates/components/ui-table/cell/cell-title-message.hbs
@@ -1,9 +1,9 @@
 <div class="content">
   {{#if (eq props.options.subject 'emailSubject')}}
-    <a class="header">{{sanitize extraRecords.emailSubject}}</a>
+    <a href="#" class="header">{{sanitize extraRecords.emailSubject}}</a>
   {{else if (eq props.options.subject 'notificationTitle')}}
     {{#if extraRecords.notificationTitle}}
-      <a class="header">{{sanitize extraRecords.notificationTitle}}</a>
+      <a href="#" class="header">{{sanitize extraRecords.notificationTitle}}</a>
     {{/if}} 
   {{/if}}  
   <div class="description">

diff --git a/app/templates/components/ui-table/cell/events/view/sessions/cell-buttons.hbs b/app/templates/components/ui-table/cell/events/view/sessions/cell-buttons.hbs
@@ -3,26 +3,26 @@
     {{#ui-dropdown class='ui icon right pointing dropdown button'}}
       <i class="green checkmark icon"></i>
       <div class="menu">
-        <a role="button" class="item" {{action props.actions.acceptProposal record true}}>{{t 'With email'}}</a>
-        <a role="button" class="item" {{action props.actions.acceptProposal record false}}>{{t 'Without email'}}</a>
+        <a href="#" role="button" class="item" {{action props.actions.acceptProposal record true}}>{{t 'With email'}}</a>
+        <a href="#" role="button" class="item" {{action props.actions.acceptProposal record false}}>{{t 'Without email'}}</a>
       </div>
     {{/ui-dropdown}}
   {{/if}}
   {{#if (eq extraRecords.status 'accepted')}}
     {{#ui-dropdown class='ui icon right pointing dropdown button'}}
       <i class="blue checkmark icon"></i>
       <div class="menu">
-        <a role="button" class="item" {{action props.actions.confirmProposal record true}}>{{t 'With email'}}</a>
-        <a role="button" class="item" {{action props.actions.confirmProposal record false}}>{{t 'Without email'}}</a>
+        <a href="#" role="button" class="item" {{action props.actions.confirmProposal record true}}>{{t 'With email'}}</a>
+        <a href="#" role="button" class="item" {{action props.actions.confirmProposal record false}}>{{t 'Without email'}}</a>
       </div>
     {{/ui-dropdown}}
   {{/if}}
   {{#if (or (eq extraRecords.status 'confirmed') (eq extraRecords.status 'pending') (eq extraRecords.status 'accepted'))}}
     {{#ui-dropdown class='ui icon right pointing dropdown button'}}
       <i class="red remove icon"></i>
       <div class="menu">
-        <a role="button" class="item" {{action props.actions.rejectProposal record true}}>{{t 'With email'}}</a>
-        <a role="button" class="item" {{action props.actions.rejectProposal record false}}>{{t 'Without email'}}</a>
+        <a href="#" role="button" class="item" {{action props.actions.rejectProposal record true}}>{{t 'With email'}}</a>
+        <a href="#" role="button" class="item" {{action props.actions.rejectProposal record false}}>{{t 'Without email'}}</a>
       </div>
     {{/ui-dropdown}}
   {{/if}}

diff --git a/app/templates/components/ui-table/cell/events/view/tickets/discount-codes/cell-status.hbs b/app/templates/components/ui-table/cell/events/view/tickets/discount-codes/cell-status.hbs
@@ -1,11 +1,11 @@
 <span>
   {{#if extraRecords.isExpired}}
-    <a class="ui red label">{{t 'Expired'}}</a>
+    <a href="#" class="ui red label">{{t 'Expired'}}</a>
   {{else}}
     {{#if record}}
-      <a class="ui green label">{{t 'Active'}}</a>
+      <a href="#" class="ui green label">{{t 'Active'}}</a>
     {{else}}
-      <a class="ui yellow label">{{t 'Inactive'}}</a>
+      <a href="#" class="ui yellow label">{{t 'Inactive'}}</a>
     {{/if}}
   {{/if}}
 </span>
diff --git a/app/templates/components/ui-table/columns-dropdown.hbs b/app/templates/components/ui-table/columns-dropdown.hbs
@@ -8,7 +8,7 @@
         <a class="item" {{action 'showAllColumns' column bubbles=false}} href="#">{{messages.columnsShowAll}}</a>
         <a class="item" {{action 'hideAllColumns' column bubbles=false}} href="#">{{messages.columnsHideAll}}</a>
         <a class="item" {{action 'restoreDefaultVisibility' column bubbles=false}} href="#">{{messages.columnsRestoreDefaults}}</a>
-        <a class="item">&nbsp;</a>
+        <a class="item" href="#">&nbsp;</a>
         {{#each processedColumns as |column|}}
           {{#if column.mayBeHidden}}
             <a class='item' {{action 'toggleHidden' column bubbles=false}} href="#">

diff --git a/app/templates/components/widgets/forms/link-input.hbs b/app/templates/components/widgets/forms/link-input.hbs
@@ -34,5 +34,5 @@
       <div class="item" data-value="https">https://</div>
     </div>
   {{/ui-dropdown}}
-  {{input type='text' id='ticket_url' value=address name=name id=inputId}}
+  {{input type='text' value=address name=name id=inputId}}
 {{/if}}
diff --git a/app/templates/explore.hbs b/app/templates/explore.hbs
@@ -8,43 +8,43 @@
       {{#if filters.category}}
         <div class="ui mini label">
           {{filters.category}}
-          <a role="button" {{action 'clearFilter' 'category'}}><i class="icon close"></i></a>
+          <a href="#" role="button" {{action 'clearFilter' 'category'}}><i class="icon close"></i></a>
         </div>
       {{/if}}
       {{#if filters.sub_category}}
         <div class="ui mini label">
           {{filters.sub_category}}
-          <a role="button" {{action 'clearFilter' 'sub_category'}}><i class="icon close"></i></a>
+          <a href="#" role="button" {{action 'clearFilter' 'sub_category'}}><i class="icon close"></i></a>
         </div>
       {{/if}}
       {{#if filters.event_type}}
         <div class="ui mini label">
           {{filters.event_type}}
-          <a role="button" {{action 'clearFilter' 'event_type'}}><i class="icon close"></i></a>
+          <a href="#" role="button" {{action 'clearFilter' 'event_type'}}><i class="icon close"></i></a>
         </div>
       {{/if}}
       {{#if filters.start_date}}
         <div class="ui mini label">
           {{moment-format filters.start_date 'ddd, MMM DD'}}
-          <a role="button" {{action 'clearFilter' 'start_date'}}><i class="icon close"></i></a>
+          <a href="#" role="button" {{action 'clearFilter' 'start_date'}}><i class="icon close"></i></a>
         </div>
       {{/if}}
       {{#if filters.end_date}}
         <div class="ui mini label">
           {{moment-format filters.end_date 'ddd, MMM DD'}}
-          <a role="button" {{action 'clearFilter' 'end_date'}}><i class="icon close"></i></a>
+          <a href="#" role="button" {{action 'clearFilter' 'end_date'}}><i class="icon close"></i></a>
         </div>
       {{/if}}
       {{#if filters.ticket_type}}
         <div class="ui mini label">
           {{ticket_type}}
-          <a role="button" {{action 'clearFilter' 'ticket_type'}}><i class="icon close"></i></a>
+          <a href="#" role="button" {{action 'clearFilter' 'ticket_type'}}><i class="icon close"></i></a>
         </div>
       {{/if}}
       {{#if filters.cfs}}
         <div class="ui mini label">
           {{filters.cfs}}
-          <a role="button" {{action 'clearFilter' 'cfs'}}><i class="icon close"></i></a>
+          <a href="#" role="button" {{action 'clearFilter' 'cfs'}}><i class="icon close"></i></a>
         </div>
       {{/if}}
     </div>

diff --git a/app/templates/organizer-app.hbs b/app/templates/organizer-app.hbs
@@ -1,5 +1,5 @@
 <div class='ui secondary pointing menu'>
-  <a class='active item'>
+  <a href="#" class='active item'>
     {{t 'Organizer App'}}
   </a>
 </div>

diff --git a/package.json b/package.json
@@ -70,7 +70,7 @@
     "ember-cli-shims": "^1.2.0",
     "ember-cli-string-helpers": "^2.0.0",
     "ember-cli-stripe": "^3.0.0",
-    "ember-cli-template-lint": "^0.7.6",
+    "ember-cli-template-lint": "^2.0.0",
     "ember-cli-uglify": "^3.0.0",
     "ember-composable-helpers": "^3.1.0",
     "ember-config-service": "^1.0.0",