Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket Order: User able to add invalid email #5277

Closed
mariobehling opened this issue Oct 9, 2020 · 12 comments · Fixed by #5690
Closed

Ticket Order: User able to add invalid email #5277

mariobehling opened this issue Oct 9, 2020 · 12 comments · Fixed by #5690

Comments

@mariobehling
Copy link
Member

A user could get a ticket and add an invalid email. Compare at https://eventyay.com/orders/d2b49133-ddc1-4f77-865e-f12cb8e24108/view

Expected:

  • User should only be able to add valid emails
  • Question: For the first ticket should we limit this and only allow the user to use their confirmed email for free tickets? How do other systems like eventbrite do it?

Screenshot from 2020-10-09 21-44-14

@iamareebjamal
Copy link
Member

only allow the user to use their confirmed email for free tickets?

This is the only way to ensure correct email. Because the email entered above by the user is a valid email address, it just doesn't exist

@iamareebjamal
Copy link
Member

Eventbrite lets you order even free tickets on invalid emails

@hardhikgupta
Copy link

hardhikgupta commented Oct 19, 2020

I want to work on this issue Please assign It to me and guide me please @hardhikgupta

@akashprasher
Copy link
Member

Let the email be the same as the user email(logged). If a user wants to use another email instead of default we can verify it. Just like an OTP system. We can provide an edit icon if the user wants to use another email otherwise, it stays at default.

@akashprasher
Copy link
Member

Just Like this

image

@mariobehling
Copy link
Member Author

Of course OTP implmentation would be nice, but it is out of scope at the moment as this would mean we have to implement a gateway or take care of it ourselves.

For now, it would be nice if it is verified that the field has a real email. In the example it is not a real email name.something@gmail - is missing the .com for example. So, this is the issue to solve here. Thanks

@aryamanprince
Copy link
Contributor

Can i work on it if no one is working?
I think it would be handy to use regular expressions to compare email entered with valid email address and hence we can validate email addresses.

@iamareebjamal
Copy link
Member

Go ahead

@aryamanprince
Copy link
Contributor

Screenshot from 2020-11-16 09-32-13

you want a check at this location?
if you could tell me working directory it will be highly helpful..

@RahulBansal123
Copy link
Member

can i work on this?

@aryamanprince
Copy link
Contributor

i am currently working on it

@divyamtayal
Copy link
Member

I am working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants