Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Invalid Email is no longer allowed #5689

Closed
wants to merge 1 commit into from
Closed

fix: Invalid Email is no longer allowed #5689

wants to merge 1 commit into from

Conversation

RahulBansal123
Copy link
Member

Fixes #5277

Short description of what this resolves:

A User can now no longer add invalid Email Addresses.

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Nov 18, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/5rdnw07zx
✅ Preview: https://open-event-frontend-git-newemailbranch.eventyay.vercel.app

@lgtm-com
Copy link

lgtm-com bot commented Nov 18, 2020

This pull request introduces 12 alerts when merging fbc22c7 into aa99edd - view on LGTM.com

new alerts:

  • 12 for Useless regular-expression character escape

@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #5689 (fbc22c7) into development (5d34f21) will decrease coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5689      +/-   ##
===============================================
- Coverage        23.72%   23.48%   -0.24%     
===============================================
  Files              498      508      +10     
  Lines             5277     5377     +100     
  Branches            47       47              
===============================================
+ Hits              1252     1263      +11     
- Misses            4017     4106      +89     
  Partials             8        8              
Impacted Files Coverage Δ
app/utils/validators.js 90.00% <ø> (ø)
app/components/forms/user-payment-info-form.js 26.66% <0.00%> (-1.91%) ⬇️
app/components/modals/modal-base.js 22.85% <0.00%> (-1.39%) ⬇️
app/router.js 100.00% <0.00%> (ø)
app/routes/index.js 78.57% <0.00%> (ø)
app/components/forms/admin/settings/billing.js 0.00% <0.00%> (ø)
app/controllers/events/view/tickets/orders/list.js 0.00% <0.00%> (ø)
.../controllers/events/view/tickets/attendees/list.js 0.00% <0.00%> (ø)
app/components/modals/add-room-modal.js 7.69% <0.00%> (ø)
app/components/modals/room-info-modal.js 0.00% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d34f21...fbc22c7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ticket Order: User able to add invalid email
1 participant