Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Addition of Fields for reCAPTCHA #3182

Merged
merged 7 commits into from
Jul 2, 2019
Merged

feat: Addition of Fields for reCAPTCHA #3182

merged 7 commits into from
Jul 2, 2019

Conversation

kushthedude
Copy link
Member

References #3129

Short description of what this resolves:

  • Addition of fields in the admin console.

image

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the feature label Jun 24, 2019
@kushthedude
Copy link
Member Author

@niranjan94 @CosmicCoder96 Please Review

abhinavk96
abhinavk96 suggested changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@abhinavk96 abhinavk96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All other components have a test file, add the test file here too.

@kushthedude
Copy link
Member Author

@CosmicCoder96 did the requested changes, Please review

@kushthedude kushthedude mentioned this pull request Jun 26, 2019
Closed
@kushthedude
Copy link
Member Author

@CosmicCoder96 @niranjan94 , Please review

@niranjan94 niranjan94 merged commit f5b35e6 into fossasia:development Jul 2, 2019
@kushthedude kushthedude deleted the keys branch July 13, 2019 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavk96 abhinavk96 abhinavk96 approved these changes

@niranjan94 niranjan94 Awaiting requested review from niranjan94

@uds5501 uds5501 Awaiting requested review from uds5501

@shreyanshdwivedi shreyanshdwivedi Awaiting requested review from shreyanshdwivedi

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kushthedude @abhinavk96 @niranjan94