Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add attendee form step in event checklist #3191

Merged
merged 1 commit into from
Jun 25, 2019
Merged

feat: Add attendee form step in event checklist #3191

merged 1 commit into from
Jun 25, 2019

Conversation

uds5501
Copy link
Contributor

@uds5501 uds5501 commented Jun 24, 2019

Fixes #3175 and #3188

Changes proposed in this pull request:

  • adds attendee form to the event checklist

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Screenshot from 2019-06-24 22-56-50

@auto-label auto-label bot added the feature label Jun 24, 2019
@uds5501
Copy link
Contributor Author

uds5501 commented Jun 24, 2019

@mrsaicharan1 @shreyanshdwivedi @kushthedude please review :D

Anupam-dagar
Anupam-dagar approved these changes Jun 24, 2019
View reviewed changes
Copy link
Member

@Anupam-dagar Anupam-dagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

mrsaicharan1
mrsaicharan1 approved these changes Jun 25, 2019
View reviewed changes
Copy link
Member

@mrsaicharan1 mrsaicharan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@abhinavk96 abhinavk96 merged commit 87ebd01 into fossasia:development Jun 25, 2019
@uds5501 uds5501 mentioned this pull request Jun 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavk96 abhinavk96 abhinavk96 approved these changes

@Anupam-dagar Anupam-dagar Anupam-dagar approved these changes

@mrsaicharan1 mrsaicharan1 mrsaicharan1 approved these changes

@shreyanshdwivedi shreyanshdwivedi shreyanshdwivedi approved these changes

@kushthedude kushthedude kushthedude approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Event Dashboard : Include the presence of custom attendee form in Event Checklist
6 participants
@uds5501 @abhinavk96 @Anupam-dagar @mrsaicharan1 @shreyanshdwivedi @kushthedude