New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Orientation of Ticket Input #3205

Merged

abhinavk96 merged 1 commit into fossasia:development from kushthedude:orientation

Jun 27, 2019

Member

kushthedude commented Jun 27, 2019

Fixes #3204

Short description of what this resolves:

Removed extra repetition of Ticket Price

Screenshot :

Checklist

I have read the Contribution & Best practices Guide.
My branch is up-to-date with the Upstream development branch.
The acceptance, integration, unit tests and linter pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)


          Fixing Orientation of Ticket Input

edd0b8a

auto-label bot added the fix label

Member Author

kushthedude commented Jun 27, 2019

@uds5501 @shreyanshdwivedi @CosmicCoder96 @niranjan94 Please review

Member

mrsaicharan1 commented Jun 27, 2019

@kushthedude My latest PR handles this as well. There was a whole duplicate code segment. I've removed it. Close this.

Member

mrsaicharan1 commented Jun 27, 2019

#3194 Check here.

Member Author

kushthedude commented Jun 27, 2019

#3194 Check here.

Thanks, I think I missed up here

kushthedude closed this

kushthedude reopened this

abhinavk96 approved these changes

View reviewed changes

abhinavk96 merged commit 974e2f5 into fossasia:development

kushthedude deleted the orientation branch

July 13, 2019 21:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix