fix: Preventing Overflow #3217
Merged
fix: Preventing Overflow #3217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shreyanshdwivedi @uds5501 Please Review ! |
uds5501
suggested changes
Jun 28, 2019
| @@ -49,56 +49,6 @@ export default ModalBase.extend(FormMixin, { | |||
| prompt : this.l10n.t('Please give us your tax ID') | |||
| } | |||
| ] | |||
| }, | |||
| taxInvoiceCompany: { | |||
There was a problem hiding this comment.
@kushthedude I don't think that the issue specified anywhere to remove the validations.
There was a problem hiding this comment.
@uds5501 The validations which I removed were of optional fields of which tick box was recently removed, I dont think this fields should be mandatory unless and until event organiser is a firm.
@shreyanshdwivedi @mrsaicharan1 Your views ?
|
@CosmicCoder96 @niranjan94 Please Review |
niranjan94
suggested changes
Jun 28, 2019
There was a problem hiding this comment.
@kushthedude when the issue is for fixing an overflow, then please fix only that in the PR. Remove all unrelated changes from this.
|
@niranjan94 Removed all unwanted changes, Please Review |
niranjan94
approved these changes
Jun 28, 2019
niranjan94
changed the title
|
@CosmicCoder96 Review Please |
uds5501
approved these changes
Jun 28, 2019
abhinavk96
approved these changes
Jun 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3164
Changes proposed in this pull request:
UI ModalChecklist
developmentbranch.