feat: Implemented event invoice table for organizers #3230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrsaicharan1
force-pushed
the
invoice-table
branch
5 times, most recently
from
19c862d to
946cf2c
Compare
Anupam-dagar
suggested changes
Jul 3, 2019
Anupam-dagar
reviewed
Jul 3, 2019
mrsaicharan1
force-pushed
the
invoice-table
branch
from
946cf2c to
b66aff9
Compare
niranjan94
suggested changes
Jul 4, 2019
mrsaicharan1
force-pushed
the
invoice-table
branch
3 times, most recently
from
a43b045 to
5a2317f
Compare
niranjan94
suggested changes
Jul 4, 2019
mrsaicharan1
force-pushed
the
invoice-table
branch
from
6a44229 to
575aebb
Compare
Yeah, just saw your merged PR. I considered refactoring after this was merged but I'll do it right now as the ember tables are functional |
niranjan94
suggested changes
Jul 5, 2019
mrsaicharan1
changed the title
mrsaicharan1
force-pushed
the
invoice-table
branch
from
18331a2 to
221c7a4
Compare
|
Use ember tables for all pending and past too. |
Pending & past invoices ? What does that mean? |
niranjan94
suggested changes
Jul 8, 2019
You understood it correctly 😄 |
kushthedude
reviewed
Jul 8, 2019
tests/unit/routes/app/templates/account/billing-info/invoices/list-test.js
Outdated
Show resolved
Hide resolved
mrsaicharan1
force-pushed
the
invoice-table
branch
from
7347220 to
6fa5635
Compare
niranjan94
suggested changes
Jul 9, 2019
mrsaicharan1
force-pushed
the
invoice-table
branch
from
3bf8558 to
770f48a
Compare
mrsaicharan1
force-pushed
the
invoice-table
branch
3 times, most recently
from
cfcb564 to
863a70e
Compare
mrsaicharan1
force-pushed
the
invoice-table
branch
from
e15ebe7 to
aa2ad13
Compare
uds5501
previously approved these changes
Aug 7, 2019
abhinavk96
suggested changes
Aug 7, 2019
mrsaicharan1
dismissed stale reviews from uds5501 and shreyanshdwivedi
via
172b1f1
mrsaicharan1
force-pushed
the
invoice-table
branch
from
172b1f1 to
b10b014
Compare
|
I have shifted the logic to controllers & removed repetitive template code. Please have a look now. |
|
@CosmicCoder96 Made the requested changes. Please have a look. |
uds5501
approved these changes
Aug 13, 2019
abhinavk96
approved these changes
Aug 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3118
Short description of what this resolves:
This feature adds the tables required for event invoices which shows the upcoming, paid and due event invoices along with relevant information.
Screenshots
As soon as the server implementation for event invoices are functional, the event invoices will show up here along with their respective invoice links.
Changes proposed in this pull request:
Checklist
developmentbranch.